Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2991253004: [logdog] Remove list functionality. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[logdog] Remove list functionality. LogDog has grown too large for this to be useful. List has been replaced in the UI with Query, which is superior for all practical purposes. Now, remove List entirely to reduce code burden. BUG=chromium:751872 TEST=Non Review-Url: https://codereview.chromium.org/2991253004 Committed: https://github.com/luci/luci-go/commit/31b62d1f3adcb115016e445192828829ae3ef081

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1028 lines, -3472 lines) Patch
M logdog/api/endpoints/coordinator/logs/v1/logs.proto View 2 chunks +0 lines, -105 lines 0 comments Download
M logdog/api/endpoints/coordinator/logs/v1/logs.pb.go View 11 chunks +58 lines, -362 lines 0 comments Download
M logdog/api/endpoints/coordinator/logs/v1/logsserver_dec.go View 1 chunk +0 lines, -15 lines 0 comments Download
M logdog/api/endpoints/coordinator/logs/v1/pb.discovery.go View 1 chunk +970 lines, -1090 lines 0 comments Download
D logdog/appengine/coordinator/endpoints/logs/list.go View 1 chunk +0 lines, -171 lines 0 comments Download
D logdog/appengine/coordinator/endpoints/logs/list_test.go View 1 chunk +0 lines, -220 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/registration/registerPrefix.go View 2 chunks +0 lines, -19 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/registration/registerPrefix_test.go View 2 chunks +0 lines, -18 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/services/registerStream.go View 2 chunks +0 lines, -17 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/services/registerStream_test.go View 2 chunks +0 lines, -21 lines 0 comments Download
D logdog/appengine/coordinator/hierarchy/component.go View 1 chunk +0 lines, -153 lines 0 comments Download
D logdog/appengine/coordinator/hierarchy/componentID.go View 1 chunk +0 lines, -212 lines 0 comments Download
D logdog/appengine/coordinator/hierarchy/component_test.go View 1 chunk +0 lines, -98 lines 0 comments Download
D logdog/appengine/coordinator/hierarchy/hierarchy.go View 1 chunk +0 lines, -291 lines 0 comments Download
D logdog/appengine/coordinator/hierarchy/hierarchy_test.go View 1 chunk +0 lines, -323 lines 0 comments Download
D logdog/appengine/coordinator/hierarchy/project.go View 1 chunk +0 lines, -70 lines 0 comments Download
M logdog/client/cli/main.go View 1 chunk +0 lines, -1 line 0 comments Download
D logdog/client/cli/subcommandList.go View 1 chunk +0 lines, -166 lines 0 comments Download
M logdog/client/coordinator/client_test.go View 1 1 chunk +0 lines, -4 lines 0 comments Download
D logdog/client/coordinator/list.go View 1 chunk +0 lines, -116 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
dnj
PTAL
3 years, 4 months ago (2017-08-02 23:04:24 UTC) #2
Ryan Tseng
lgtm burn it alll
3 years, 4 months ago (2017-08-03 00:25:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991253004/1
3 years, 4 months ago (2017-08-03 00:26:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/37be4dd0f3e00610)
3 years, 4 months ago (2017-08-03 00:29:53 UTC) #9
dnj
fix test
3 years, 4 months ago (2017-08-03 00:30:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991253004/20001
3 years, 4 months ago (2017-08-03 00:31:02 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 00:38:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/31b62d1f3adcb115016e445192828829ae3ef081

Powered by Google App Engine
This is Rietveld 408576698