Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: logdog/appengine/coordinator/endpoints/registration/registerPrefix.go

Issue 2991253004: [logdog] Remove list functionality. (Closed)
Patch Set: fix test Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/appengine/coordinator/endpoints/registration/registerPrefix.go
diff --git a/logdog/appengine/coordinator/endpoints/registration/registerPrefix.go b/logdog/appengine/coordinator/endpoints/registration/registerPrefix.go
index 7c9e3e91d2d8a35f629400fb02f4159a1a2041f4..83fd99daea345e103afca5011f1b645ad2e5e04c 100644
--- a/logdog/appengine/coordinator/endpoints/registration/registerPrefix.go
+++ b/logdog/appengine/coordinator/endpoints/registration/registerPrefix.go
@@ -26,7 +26,6 @@ import (
"github.com/luci/luci-go/logdog/api/endpoints/coordinator/registration/v1"
"github.com/luci/luci-go/logdog/appengine/coordinator"
"github.com/luci/luci-go/logdog/appengine/coordinator/endpoints"
- "github.com/luci/luci-go/logdog/appengine/coordinator/hierarchy"
"github.com/luci/luci-go/logdog/common/types"
"golang.org/x/net/context"
@@ -109,24 +108,6 @@ func (s *server) RegisterPrefix(c context.Context, req *logdog.RegisterPrefixReq
return nil, grpcutil.Internal
}
- // Best effort: register the stream prefix hierarchy components, including the
- // separator.
- //
- // Determine which hierarchy components we need to add.
- comps := hierarchy.Components(prefix.AsPathPrefix(""), false)
- if comps, err = hierarchy.Missing(c, comps); err != nil {
- log.WithError(err).Warningf(c, "Failed to probe for missing hierarchy components.")
- }
-
- // Before we go into transaction, try and put these entries. This should not
- // be contested, since components don't share an entity root.
- //
- // If this fails, that's okay; we'll handle this when the stream gets
- // registered.
- if err := hierarchy.PutMulti(c, comps); err != nil {
- log.WithError(err).Infof(c, "Failed to add missing hierarchy components.")
- }
-
// The prefix doesn't appear to be registered. Prepare to transactionally
// register it.
now := clock.Now(c).UTC()

Powered by Google App Engine
This is Rietveld 408576698