Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: logdog/appengine/coordinator/endpoints/services/registerStream_test.go

Issue 2991253004: [logdog] Remove list functionality. (Closed)
Patch Set: fix test Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/appengine/coordinator/endpoints/services/registerStream_test.go
diff --git a/logdog/appengine/coordinator/endpoints/services/registerStream_test.go b/logdog/appengine/coordinator/endpoints/services/registerStream_test.go
index b66d9ac72cad9e6b5b6d53aaf62a79e24731dec6..41363eeabf0fb5ddf1be7abf8c0bbee7e0afa0ff 100644
--- a/logdog/appengine/coordinator/endpoints/services/registerStream_test.go
+++ b/logdog/appengine/coordinator/endpoints/services/registerStream_test.go
@@ -28,7 +28,6 @@ import (
"github.com/luci/luci-go/logdog/api/logpb"
"github.com/luci/luci-go/logdog/appengine/coordinator"
ct "github.com/luci/luci-go/logdog/appengine/coordinator/coordinatorTest"
- "github.com/luci/luci-go/logdog/appengine/coordinator/hierarchy"
"github.com/luci/luci-go/logdog/common/types"
"github.com/luci/luci-go/luci_config/common/cfgtypes"
"golang.org/x/net/context"
@@ -126,26 +125,6 @@ func TestRegisterStream(t *testing.T) {
// No archival request yet.
So(env.ArchivalPublisher.Hashes(), ShouldResemble, []string{})
- // Should have name components.
- getNameComponents := func(b string) []string {
- l, err := hierarchy.Get(c, hierarchy.Request{Project: string(tls.Project), PathBase: b})
- if err != nil {
- panic(err)
- }
- names := make([]string, len(l.Comp))
- for i, e := range l.Comp {
- names[i] = e.Name
- if e.Stream {
- names[i] += "$"
- }
- }
- return names
- }
- So(getNameComponents(""), ShouldResemble, []string{"testing"})
- So(getNameComponents("testing"), ShouldResemble, []string{"+"})
- So(getNameComponents("testing/+"), ShouldResemble, []string{"foo"})
- So(getNameComponents("testing/+/foo"), ShouldResemble, []string{"bar$"})
-
Convey(`Can register the stream again (idempotent).`, func() {
env.Clock.Set(created.Add(10 * time.Minute))
« no previous file with comments | « logdog/appengine/coordinator/endpoints/services/registerStream.go ('k') | logdog/appengine/coordinator/hierarchy/component.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698