[logdog] Replace list view with query view.

[logdog] Replace list view with query view.

The list view is near-useless, as the log stream space is too large to
effectively navigate through list clicks. Replace it with a query view.

This query view is fairly simple at the moment. The intent is to improve
it over time.

BUG=chromium:751872
TEST=local

Review-Url: https://codereview.chromium.org/2991253003
Committed: https://github.com/luci/luci-go/commit/6ad55f6eef0b637bacc1782dc260803facb1b021

[dnj, 2017-08-02 22:29:16]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-08-02 22:29:16]

PTAL

[dnj, 2017-08-02 22:31:23]

Demo version online at:
https://1890-47c0ca7-tainted-dnj-dot-luci-logdog.appspot.com

[dnj, 2017-08-02 23:09:00]

Description was changed from

==========
[logdog] Replace list view with query view.

The list view is near-useless, as the log stream space is too large to
effectively navigate through list clicks. Replace it with a query view.

This query view is fairly simple at the moment. The intent is to improve
it over time.

BUG=None
TEST=local
==========

to

==========
[logdog] Replace list view with query view.

The list view is near-useless, as the log stream space is too large to
effectively navigate through list clicks. Replace it with a query view.

This query view is fairly simple at the moment. The intent is to improve
it over time.

BUG=chromium:751872
TEST=local
==========

[Ryan Tseng, 2017-08-02 23:34:09]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-08-02 23:34:09]

lgtm + comments

main comment is that the form doesn't act like a form.

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
File web/inc/logdog-query-view/logdog-query-panel.html (right):

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
web/inc/logdog-query-view/logdog-query-panel.html:101: this.dispatchEvent(new
CustomEvent('query-selected'));
This should activate on pressing enter on any of the form (paper-input) fields
too.

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
File web/inc/logdog-query-view/logdog-query-view.html (right):

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
web/inc/logdog-query-view/logdog-query-view.html:112: sharedPrefix: {
Whats this? (document)

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
web/inc/logdog-query-view/logdog-query-view.html:118: queryResults: {
What do results look like? Array of strings? (document)

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/v...
File web/inc/logdog-query-view/view.ts (right):

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/v...
web/inc/logdog-query-view/view.ts:29: export class QueryView {
In general, more comments please, namely on exported classes and its primary
interface.  QueryView is the backend implementation of.... you use it by....
caveats are.... etc.

[dnj, 2017-08-03 00:07:31]

handle enter for submit

[dnj, 2017-08-03 00:07:37]

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
File web/inc/logdog-query-view/logdog-query-panel.html (right):

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
web/inc/logdog-query-view/logdog-query-panel.html:101: this.dispatchEvent(new
CustomEvent('query-selected'));
On 2017/08/02 23:34:09, Ryan Tseng wrote:
> This should activate on pressing enter on any of the form (paper-input) fields
> too.

Done.

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
File web/inc/logdog-query-view/logdog-query-view.html (right):

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
web/inc/logdog-query-view/logdog-query-view.html:112: sharedPrefix: {
On 2017/08/02 23:34:09, Ryan Tseng wrote:
> Whats this? (document)

Done.

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/l...
web/inc/logdog-query-view/logdog-query-view.html:118: queryResults: {
On 2017/08/02 23:34:09, Ryan Tseng wrote:
> What do results look like? Array of strings? (document)

Done.

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/v...
File web/inc/logdog-query-view/view.ts (right):

https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/v...
web/inc/logdog-query-view/view.ts:29: export class QueryView {
On 2017/08/02 23:34:09, Ryan Tseng wrote:
> In general, more comments please, namely on exported classes and its primary
> interface.  QueryView is the backend implementation of.... you use it by....
> caveats are.... etc.

Done.

[Ryan Tseng, 2017-08-03 00:09:27]

lgtm

[dnj, 2017-08-03 00:09:27]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-08-03 00:09:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-03 00:15:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501718967875040,
"parent_rev": "e74d1c071c854fc4b50e6d980f03164b03cdc61a", "commit_rev":
"6ad55f6eef0b637bacc1782dc260803facb1b021"}

[commit-bot: I haz the power, 2017-08-03 00:15:11]

Description was changed from

==========
[logdog] Replace list view with query view.

The list view is near-useless, as the log stream space is too large to
effectively navigate through list clicks. Replace it with a query view.

This query view is fairly simple at the moment. The intent is to improve
it over time.

BUG=chromium:751872
TEST=local
==========

to

==========
[logdog] Replace list view with query view.

The list view is near-useless, as the log stream space is too large to
effectively navigate through list clicks. Replace it with a query view.

This query view is fairly simple at the moment. The intent is to improve
it over time.

BUG=chromium:751872
TEST=local

Review-Url: https://codereview.chromium.org/2991253003
Committed:
https://github.com/luci/luci-go/commit/6ad55f6eef0b637bacc1782dc260803facb1b021
==========

[commit-bot: I haz the power, 2017-08-03 00:15:15]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/6ad55f6eef0b637bacc1782dc260803facb1b021