Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Issue 2991253003: [logdog] Replace list view with query view. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[logdog] Replace list view with query view. The list view is near-useless, as the log stream space is too large to effectively navigate through list clicks. Replace it with a query view. This query view is fairly simple at the moment. The intent is to improve it over time. BUG=chromium:751872 TEST=local Review-Url: https://codereview.chromium.org/2991253003 Committed: https://github.com/luci/luci-go/commit/6ad55f6eef0b637bacc1782dc260803facb1b021

Patch Set 1 #

Total comments: 8

Patch Set 2 : comments #

Patch Set 3 : handle enter for submit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -529 lines) Patch
M web/apps/logdog-app/elements/elements.html View 1 chunk +2 lines, -1 line 0 comments Download
M web/apps/logdog-app/elements/logdog-app/logdog-app.html View 5 chunks +10 lines, -13 lines 0 comments Download
M web/apps/logdog-app/elements/routing.html View 1 chunk +3 lines, -3 lines 0 comments Download
M web/inc/apps/logdog-app/main.ts View 1 chunk +1 line, -0 lines 0 comments Download
D web/inc/logdog-list-view/logdog-list-view.html View 1 chunk +0 lines, -512 lines 0 comments Download
A web/inc/logdog-query-view/logdog-query-panel.html View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
A web/inc/logdog-query-view/logdog-query-view.html View 1 1 chunk +159 lines, -0 lines 0 comments Download
A web/inc/logdog-query-view/view.ts View 1 1 chunk +127 lines, -0 lines 0 comments Download
M web/inc/logdog-stream-view/logdog-stream-view.html View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
dnj
PTAL
3 years, 4 months ago (2017-08-02 22:29:16 UTC) #2
dnj
Demo version online at: https://1890-47c0ca7-tainted-dnj-dot-luci-logdog.appspot.com
3 years, 4 months ago (2017-08-02 22:31:23 UTC) #3
Ryan Tseng
lgtm + comments main comment is that the form doesn't act like a form. https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/logdog-query-panel.html ...
3 years, 4 months ago (2017-08-02 23:34:09 UTC) #6
dnj
handle enter for submit
3 years, 4 months ago (2017-08-03 00:07:31 UTC) #7
dnj
https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/logdog-query-panel.html File web/inc/logdog-query-view/logdog-query-panel.html (right): https://codereview.chromium.org/2991253003/diff/1/web/inc/logdog-query-view/logdog-query-panel.html#newcode101 web/inc/logdog-query-view/logdog-query-panel.html:101: this.dispatchEvent(new CustomEvent('query-selected')); On 2017/08/02 23:34:09, Ryan Tseng wrote: > ...
3 years, 4 months ago (2017-08-03 00:07:37 UTC) #8
Ryan Tseng
lgtm
3 years, 4 months ago (2017-08-03 00:09:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991253003/40001
3 years, 4 months ago (2017-08-03 00:09:34 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 00:15:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/6ad55f6eef0b637bacc1782dc260803facb1b021

Powered by Google App Engine
This is Rietveld 408576698