Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: dashboard/dashboard/add_histograms_queue_test.py

Issue 2990293002: Revision Info into GenericSet (Closed)
Patch Set: Rebase on master Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/add_histograms_queue.py ('k') | dashboard/dashboard/add_histograms_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/add_histograms_queue_test.py
diff --git a/dashboard/dashboard/add_histograms_queue_test.py b/dashboard/dashboard/add_histograms_queue_test.py
index b90bbaba975cb60ef5473b5af944c93f3c94bb75..389f6c7a86aa2bb4ea6a987acbea0955ba71af44 100644
--- a/dashboard/dashboard/add_histograms_queue_test.py
+++ b/dashboard/dashboard/add_histograms_queue_test.py
@@ -19,21 +19,19 @@ from dashboard.models import anomaly
from dashboard.models import graph_data
from dashboard.models import histogram
from tracing.value import histogram as histogram_module
-
+from tracing.value.diagnostics import reserved_infos
TEST_HISTOGRAM = {
'allBins': {'1': [1], '3': [1], '4': [1]},
'binBoundaries': [1, [1, 1000, 20]],
'diagnostics': {
- 'revisions': {
- 'angle': [],
- 'catapult': [],
- 'chromium': [],
- 'chromiumCommitPosition': [123],
- 'skia': [],
- 'type': 'RevisionInfo',
- 'v8': ['4cd34ad3320db114ad3a2bd2acc02aba004d0cb4'],
- 'webrtc': []
+ reserved_infos.CHROMIUM_COMMIT_POSITIONS.name: {
+ 'values': [123],
+ 'type': 'GenericSet'
+ },
+ reserved_infos.V8_REVISIONS.name: {
+ 'values': ['4cd34ad3320db114ad3a2bd2acc02aba004d0cb4'],
+ 'type': 'GenericSet'
},
'owners': '68e5b3bd-829c-4f4f-be3a-98a94279ccf0',
'telemetry': 'ec2c0cdc-cd9f-4736-82b4-6ffc3d76e3eb'
@@ -351,7 +349,8 @@ class AddHistogramsQueueTest(testing_common.TestCase):
test_path = 'Chromium/win7/suite/metric'
test_key = utils.TestKey(test_path)
hist = copy.deepcopy(TEST_HISTOGRAM)
- hist['diagnostics']['revisions']['catapult'] = [123, 456]
+ hist['diagnostics']['catapult revisions'] = {
+ 'type': 'GenericSet', 'values': [123, 456]}
with self.assertRaises(add_histograms_queue.BadRequestError):
add_histograms_queue.AddRow(hist, test_key, 123, test_path, False)
« no previous file with comments | « dashboard/dashboard/add_histograms_queue.py ('k') | dashboard/dashboard/add_histograms_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698