Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: dashboard/dashboard/add_histograms.py

Issue 2990293002: Revision Info into GenericSet (Closed)
Patch Set: Rebase on master Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/add_histograms_queue.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/add_histograms.py
diff --git a/dashboard/dashboard/add_histograms.py b/dashboard/dashboard/add_histograms.py
index f6c64075649f57affe4ef361bbebd1a5159506e3..abf5e7fcfbe8d25c1286c9b48db7a9d0ce10f332 100644
--- a/dashboard/dashboard/add_histograms.py
+++ b/dashboard/dashboard/add_histograms.py
@@ -226,19 +226,18 @@ def _GetMasterBotBenchmarkFromHistogram(hist):
def ComputeRevision(histograms):
_CheckRequest(len(histograms) > 0, 'Must upload at least one histogram')
diagnostics = histograms.GetFirstHistogram().diagnostics
- _CheckRequest(reserved_infos.REVISIONS.name in diagnostics,
- 'Histograms must have RevisionInfo attached')
- revision_info = diagnostics[reserved_infos.REVISIONS.name]
+ _CheckRequest(reserved_infos.CHROMIUM_COMMIT_POSITIONS.name in diagnostics,
+ 'Histograms must have Chromium commit position attached')
+ chromium_commit_position = list(diagnostics[
+ reserved_infos.CHROMIUM_COMMIT_POSITIONS.name])
- _CheckRequest(
- isinstance(revision_info.chromium_commit_position, list) and
- len(revision_info.chromium_commit_position) == 1,
- 'RevisionInfo chromium_commit_position must have 1 value')
+ _CheckRequest(len(chromium_commit_position) == 1,
+ 'Chromium commit position must have 1 value')
# TODO(eakuefner): Allow users to specify other types of revisions to be used
# for computing revisions of dashboard points. See
# https://github.com/catapult-project/catapult/issues/3623.
- return revision_info.chromium_commit_position[0]
+ return chromium_commit_position[0]
def InlineDenseSharedDiagnostics(histograms):
« no previous file with comments | « no previous file | dashboard/dashboard/add_histograms_queue.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698