Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: tracing/tracing/value/histogram_unittest.py

Issue 2990293002: Revision Info into GenericSet (Closed)
Patch Set: Rebase on master Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/ui/diagnostic_span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_unittest.py
diff --git a/tracing/tracing/value/histogram_unittest.py b/tracing/tracing/value/histogram_unittest.py
index 015060ff9b55fd6e0543bb79b6c144e356907a6b..a398db905b23078547d0270069bd4b93725521b2 100644
--- a/tracing/tracing/value/histogram_unittest.py
+++ b/tracing/tracing/value/histogram_unittest.py
@@ -698,31 +698,6 @@ class BuildbotInfoUnittest(unittest.TestCase):
self.assertNotEqual(info0, info1)
-class RevisionInfoUnittest(unittest.TestCase):
- def testRoundtrip(self):
- info = histogram.RevisionInfo({
- 'chromiumCommitPosition': 42,
- 'v8CommitPosition': 57,
- 'chromium': ['b10563e'],
- 'v8': ['0a12a6'],
- 'catapult': ['e6e086'],
- 'angle': ['d7b1ab', 'da9fb0'],
- 'skia': ['966bb3', 'db402c'],
- 'webrtc': ['277b25', 'f8b262'],
- })
- d = info.AsDict()
- clone = diagnostic.Diagnostic.FromDict(d)
- self.assertEqual(ToJSON(d), ToJSON(clone.AsDict()))
- self.assertEqual(clone.chromium_commit_position, 42)
- self.assertEqual(clone.v8_commit_position, 57)
- self.assertEqual(clone.chromium[0], 'b10563e')
- self.assertEqual(clone.v8[0], '0a12a6')
- self.assertEqual(clone.catapult[0], 'e6e086')
- self.assertEqual(clone.angle[1], 'da9fb0')
- self.assertEqual(clone.skia[1], 'db402c')
- self.assertEqual(clone.webrtc[1], 'f8b262')
-
-
class TelemetryInfoUnittest(unittest.TestCase):
def testRoundtrip(self):
info = histogram.TelemetryInfo()
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/ui/diagnostic_span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698