Reland of RTCVideoEncoder: Report H264 profile information to WebRTC

Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > > WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > > WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > > https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > > https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541, 735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed: https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a96527d59ea5e9
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541, 735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed: https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1d7106b55160d

TBR=emircan@chromium.org,niklase@chromium.org,phoglund@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541, 735959
Review-Url: https://codereview.chromium.org/2985263002
Cr-Commit-Position: refs/heads/master@{#491338}
Committed: https://chromium.googlesource.com/chromium/src/+/4d10d214a1783c08dd1fb887600e408d87f520e3

[magjed_chromium, 2017-07-28 09:20:00]

Created Reland of TCVideoEncoder: Report H264 profile information to WebRTC

[magjed_chromium, 2017-07-28 09:20:17]

Description was changed from

==========
Reland of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1
id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like
HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > >
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > >
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541,735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541,735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed:
https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1...

TBR=emircan@chromium.org,niklase@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

to

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like
HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > >
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > >
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541,735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541,735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed:
https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1...

TBR=emircan@chromium.org,niklase@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

[magjed_chromium, 2017-07-31 16:58:07]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-31 16:58:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[magjed_chromium, 2017-07-31 17:48:25]

Emircan - please take a look.

This will keep the perf tests happy. We will still get two H264 codecs in the
SDP list, but that's intended behavior.

[commit-bot: I haz the power, 2017-07-31 18:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-31 18:29:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[emircan, 2017-08-02 03:42:22]

lgtm % nits. 

Btw I am still confused by the Android using SW over HW because AFAIK there is
no OpenH264 due to license issues. Maybe this is mismatch between encode and
decode codec? Either way, lets see if this fixes it.

https://codereview.chromium.org/2985263002/diff/190001/chrome/test/data/webrt...
File chrome/test/data/webrtc/munge_sdp.js (right):

https://codereview.chromium.org/2985263002/diff/190001/chrome/test/data/webrt...
chrome/test/data/webrtc/munge_sdp.js:60: * will select the first codec with the
given name.
Can you also note that HW codecs are after SW codecs in this case to make the
assumption clear?

https://codereview.chromium.org/2985263002/diff/190001/chrome/test/data/webrt...
chrome/test/data/webrtc/munge_sdp.js:172: * codec ID, codec name or bitrate. If
|searchBackwards| is true, it will return
Replace |searchBackwards| with |lastInstance|

[magjed_chromium, 2017-08-02 08:51:15]

On 2017/08/02 03:42:22, emircan wrote:
> lgtm % nits. 
> 
> Btw I am still confused by the Android using SW over HW because AFAIK there is
> no OpenH264 due to license issues. Maybe this is mismatch between encode and
> decode codec? Either way, lets see if this fixes it.

I added a comment to issue 688541 to clarify what happened. There is no SW H264
on Android, but the tests used to use SW VP8 which was the first codec in the
SDP list. When putting HW codecs first, HW H264 would be first in the SDP list
and tests that didn't re-arrange the codec list would use that one instead.

https://codereview.chromium.org/2985263002/diff/190001/chrome/test/data/webrt...
File chrome/test/data/webrtc/munge_sdp.js (right):

https://codereview.chromium.org/2985263002/diff/190001/chrome/test/data/webrt...
chrome/test/data/webrtc/munge_sdp.js:60: * will select the first codec with the
given name.
On 2017/08/02 03:42:22, emircan wrote:
> Can you also note that HW codecs are after SW codecs in this case to make the
> assumption clear?

Done.

https://codereview.chromium.org/2985263002/diff/190001/chrome/test/data/webrt...
chrome/test/data/webrtc/munge_sdp.js:172: * codec ID, codec name or bitrate. If
|searchBackwards| is true, it will return
On 2017/08/02 03:42:21, emircan wrote:
> Replace |searchBackwards| with |lastInstance|

Done.

[magjed_chromium, 2017-08-02 09:33:53]

Description was changed from

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like
HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > >
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > >
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541,735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541,735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed:
https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1...

TBR=emircan@chromium.org,niklase@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

to

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like
HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > >
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > >
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541,735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541,735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed:
https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1...

TBR=emircan@chromium.org,niklase@chromium.org,phoglund@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

[magjed_chromium, 2017-08-02 09:34:03]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-02 09:34:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[magjed_chromium, 2017-08-02 11:03:00]

magjed@chromium.org changed reviewers:
+ phoglund@chromium.org

[commit-bot: I haz the power, 2017-08-02 11:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-02 11:20:01]

Dry run: This issue passed the CQ dry run.

[magjed_chromium, 2017-08-02 11:52:14]

The CQ bit was checked by magjed@chromium.org

[magjed_chromium, 2017-08-02 11:52:15]

The patchset sent to the CQ was uploaded after l-g-t-m from emircan@chromium.org
Link to the patchset: https://codereview.chromium.org/2985263002/#ps230001
(title: "Add default argument to SetDefaultVideoCodec")

[commit-bot: I haz the power, 2017-08-02 11:52:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-02 11:56:06]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1501674734946990,
"parent_rev": "507ddcc274321db4f7b1819ab9b2877147179021", "commit_rev":
"4d10d214a1783c08dd1fb887600e408d87f520e3"}

[commit-bot: I haz the power, 2017-08-02 11:56:23]

Description was changed from

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like
HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > >
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > >
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541,735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541,735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed:
https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1...

TBR=emircan@chromium.org,niklase@chromium.org,phoglund@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

to

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2973253002/ )

Reason for revert:
Update test to still use HW version of H264.

Original issue's description:
> Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:190001 of https://codereview.chromium.org/2548443002/ )
> 
> Reason for revert:
> Reverting this since it's causing multiple perf regression on mac, looks like
HW encode/decode might get disabled.
> 
> Original issue's description:
> > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )
> > 
> > Reason for revert:
> > Try again.
> > 
> > Original issue's description:
> > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
(patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> > > 
> > > Reason for revert:
> > > Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> > >
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> > >
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> > >
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> > > 
> > > Original issue's description:
> > > > RTCVideoEncoder: Report H264 profile information to WebRTC
> > > >
> > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > > > information is added to the cricket::VideoCodec so that WebRTC receives
> > > > this information. Also, the mapping between media::VideoCodecProfiles
> > > > and cricket::VideoCodecs is cached so that we can send the
> > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > > > with webrtc::VideoCodecType.
> > > >
> > > > BUG=webrtc:6337
> > > >
> > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > > > Cr-Commit-Position: refs/heads/master@{#433508}
> > > 
> > > TBR=emircan@chromium.org,posciak@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:6337
> > > 
> > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> > > Cr-Commit-Position: refs/heads/master@{#433828}
> > 
> > TBR=emircan@chromium.org,posciak@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=688541,735959
> > 
> > Review-Url: https://codereview.chromium.org/2548443002
> > Cr-Commit-Position: refs/heads/master@{#484874}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
> 
> TBR=emircan@chromium.org,magjed@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688541,735959
> 
> Review-Url: https://codereview.chromium.org/2973253002
> Cr-Commit-Position: refs/heads/master@{#484960}
> Committed:
https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1...

TBR=emircan@chromium.org,niklase@chromium.org,phoglund@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959

Review-Url: https://codereview.chromium.org/2985263002
Cr-Commit-Position: refs/heads/master@{#491338}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d10d214a1783c08dd1fb887600e...
==========

[commit-bot: I haz the power, 2017-08-02 11:56:24]

Committed patchset #4 (id:230001) as
https://chromium.googlesource.com/chromium/src/+/4d10d214a1783c08dd1fb887600e...