Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2973253002: Revert of TCVideoEncoder: Report H264 profile information to WebRTC (Closed)

Created:
3 years, 5 months ago by Niklas Enbom
Modified:
3 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:190001 of https://codereview.chromium.org/2548443002/ ) Reason for revert: Reverting this since it's causing multiple perf regression on mac, looks like HW encode/decode might get disabled. Original issue's description: > Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:1 of https://codereview.chromium.org/2521923002/ ) > > Reason for revert: > Try again. > > Original issue's description: > > Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ ) > > > > Reason for revert: > > Causes these tests to fail on chromium.webrtc bots for Win and Mac: > > WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 > > WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 > > https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367 > > https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661 > > > > Original issue's description: > > > RTCVideoEncoder: Report H264 profile information to WebRTC > > > > > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs > > > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile > > > information is added to the cricket::VideoCodec so that WebRTC receives > > > this information. Also, the mapping between media::VideoCodecProfiles > > > and cricket::VideoCodecs is cached so that we can send the > > > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal > > > with webrtc::VideoCodecType. > > > > > > BUG=webrtc:6337 > > > > > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5 > > > Cr-Commit-Position: refs/heads/master@{#433508} > > > > TBR=emircan@chromium.org,posciak@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6337 > > > > Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c > > Cr-Commit-Position: refs/heads/master@{#433828} > > TBR=emircan@chromium.org,posciak@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=688541, 735959 > > Review-Url: https://codereview.chromium.org/2548443002 > Cr-Commit-Position: refs/heads/master@{#484874} > Committed: https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a96527d59ea5e9 TBR=emircan@chromium.org,magjed@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688541, 735959 Review-Url: https://codereview.chromium.org/2973253002 Cr-Commit-Position: refs/heads/master@{#484960} Committed: https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1d7106b55160d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -97 lines) Patch
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder.cc View 4 chunks +31 lines, -17 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.cc View 3 chunks +14 lines, -61 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_unittest.cc View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Niklas Enbom
Created Revert of TCVideoEncoder: Report H264 profile information to WebRTC
3 years, 5 months ago (2017-07-07 16:58:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973253002/1
3 years, 5 months ago (2017-07-07 16:58:24 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-07 16:58:25 UTC) #5
emircan
lgtm
3 years, 5 months ago (2017-07-07 16:58:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973253002/1
3 years, 5 months ago (2017-07-07 16:59:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/df6e5a5c7e7c665603f9619930a1d7106b55160d
3 years, 5 months ago (2017-07-07 16:59:59 UTC) #11
magjed_chromium
3 years, 4 months ago (2017-07-28 09:19:59 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2985263002/ by magjed@chromium.org.

The reason for reverting is: Update test to still use HW version of H264..

Powered by Google App Engine
This is Rietveld 408576698