Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2521923002: Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (Closed)

Created:
4 years, 1 month ago by magjed_chromium
Modified:
4 years, 1 month ago
Reviewers:
emircan, Pawel Osciak
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ ) Reason for revert: Causes these tests to fail on chromium.webrtc bots for Win and Mac: WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367 https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661 Original issue's description: > RTCVideoEncoder: Report H264 profile information to WebRTC > > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile > information is added to the cricket::VideoCodec so that WebRTC receives > this information. Also, the mapping between media::VideoCodecProfiles > and cricket::VideoCodecs is cached so that we can send the > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal > with webrtc::VideoCodecType. > > BUG=webrtc:6337 > > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5 > Cr-Commit-Position: refs/heads/master@{#433508} TBR=emircan@chromium.org,posciak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6337 Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c Cr-Commit-Position: refs/heads/master@{#433828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -99 lines) Patch
M content/renderer/media/gpu/rtc_video_encoder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder.cc View 5 chunks +29 lines, -16 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.h View 2 chunks +3 lines, -7 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.cc View 5 chunks +17 lines, -61 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_unittest.cc View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
magjed_chromium
Created Revert of RTCVideoEncoder: Report H264 profile information to WebRTC
4 years, 1 month ago (2016-11-22 10:07:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521923002/1
4 years, 1 month ago (2016-11-22 10:07:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 10:08:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c Cr-Commit-Position: refs/heads/master@{#433828}
4 years, 1 month ago (2016-11-22 10:11:19 UTC) #8
magjed_chromium
4 years ago (2016-12-01 10:22:26 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2548443002/ by magjed@chromium.org.

The reason for reverting is: Fix failing tests..

Powered by Google App Engine
This is Rietveld 408576698