Reland of RTCVideoEncoder: Report H264 profile information to WebRTC

Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #1 id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Try again.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset #3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
> WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
> WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
> https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
> https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541, 735959
Review-Url: https://codereview.chromium.org/2548443002
Cr-Commit-Position: refs/heads/master@{#484874}
Committed: https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a96527d59ea5e9

[magjed_chromium, 2016-12-01 10:22:27]

Created Reland of TCVideoEncoder: Report H264 profile information to WebRTC

[magjed_chromium, 2017-01-17 08:34:13]

Description was changed from

==========
Reland of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1
id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Fix failing tests.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6337
==========

to

==========
Reland of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1
id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Fix failing tests.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6337
==========

[magjed_chromium, 2017-01-17 08:34:13]

magjed@chromium.org changed reviewers:
- emircan@chromium.org, posciak@chromium.org

[magjed_chromium, 2017-05-05 12:26:50]

Description was changed from

==========
Reland of TCVideoEncoder: Report H264 profile information to WebRTC (patchset #1
id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Fix failing tests.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6337
==========

to

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Fix failing tests.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6337
==========

[magjed_chromium, 2017-07-04 08:01:08]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 08:01:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 08:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 08:05:24]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[magjed_chromium, 2017-07-04 08:11:00]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 08:11:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 08:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 08:24:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[magjed_chromium, 2017-07-04 08:36:46]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 08:36:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 08:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 08:46:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[magjed_chromium, 2017-07-04 13:33:00]

The CQ bit was checked by magjed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 13:33:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 14:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 14:49:44]

Dry run: This issue passed the CQ dry run.

[magjed_chromium, 2017-07-05 07:39:39]

Patchset #4 (id:170001) has been deleted

[magjed_chromium, 2017-07-05 07:39:49]

Patchset #3 (id:150001) has been deleted

[magjed_chromium, 2017-07-05 07:40:01]

Patchset #2 (id:130001) has been deleted

[magjed_chromium, 2017-07-05 07:40:11]

Patchset #1 (id:1) has been deleted

[magjed_chromium, 2017-07-05 07:45:21]

Description was changed from

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Fix failing tests.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6337
==========

to

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Try again.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

[magjed_chromium, 2017-07-05 07:45:21]

magjed@chromium.org changed reviewers:
+ emircan@chromium.org

[magjed_chromium, 2017-07-05 07:47:43]

emircan - please take a look.

I ran all the H264 tests locally on my Mac, and they passed. Do you know if it's
possible to run the chromium.webrtc tests before landing?

[emircan, 2017-07-05 20:13:00]

On 2017/07/05 07:47:43, magjed_chromium wrote:
> emircan - please take a look.
> 
> I ran all the H264 tests locally on my Mac, and they passed. Do you know if
it's
> possible to run the chromium.webrtc tests before landing?

I don't know of a way to run those before landing. Mac is usually reliable as it
is consistent with the local runs.

Do you remember what was the error that caused revert?

[magjed_chromium, 2017-07-06 09:35:54]

On 2017/07/05 20:13:00, emircan wrote:
> On 2017/07/05 07:47:43, magjed_chromium wrote:
> > emircan - please take a look.
> > 
> > I ran all the H264 tests locally on my Mac, and they passed. Do you know if
> it's
> > possible to run the chromium.webrtc tests before landing?
> 
> I don't know of a way to run those before landing. Mac is usually reliable as
it
> is consistent with the local runs.
> 
> Do you remember what was the error that caused revert?

I remember I tried to investigate it a bit, but couldn't understand the reason
for them failing. This CL will change some behavior, because we will start
negotiating and using other H264 profiles than baseline, and I'm not sure that
code has been tested before.

I spoke with kjellander@ and it's indeed not possible to run the chromium.webrtc
bots as try jobs, but we might add that functionality.

Are you ok with landing this CL and see what happens? If it's still causing
problems I'll revert asap and try to reproduce locally.

[emircan, 2017-07-06 17:24:40]

On 2017/07/06 09:35:54, magjed_chromium wrote:
> On 2017/07/05 20:13:00, emircan wrote:
> > On 2017/07/05 07:47:43, magjed_chromium wrote:
> > > emircan - please take a look.
> > > 
> > > I ran all the H264 tests locally on my Mac, and they passed. Do you know
if
> > it's
> > > possible to run the chromium.webrtc tests before landing?
> > 
> > I don't know of a way to run those before landing. Mac is usually reliable
as
> it
> > is consistent with the local runs.
> > 
> > Do you remember what was the error that caused revert?
> 
> I remember I tried to investigate it a bit, but couldn't understand the reason
> for them failing. This CL will change some behavior, because we will start
> negotiating and using other H264 profiles than baseline, and I'm not sure that
> code has been tested before.
> 
> I spoke with kjellander@ and it's indeed not possible to run the
chromium.webrtc
> bots as try jobs, but we might add that functionality.
> 
> Are you ok with landing this CL and see what happens? If it's still causing
> problems I'll revert asap and try to reproduce locally.

Sounds good then. lgtm.

One more question. OpenH264 encoder has ConstrainedBaseline support and HW
encoders only support Baseline right now. HW decoder doesn't receive profile
info and defaults to Main support [0]. I see you aren't touching decode code yet
in this CL, but what is your plan there?

[0]
https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_dec...

[magjed_chromium, 2017-07-07 08:31:00]

On 2017/07/06 17:24:40, emircan wrote:
> On 2017/07/06 09:35:54, magjed_chromium wrote:
> > On 2017/07/05 20:13:00, emircan wrote:
> > > On 2017/07/05 07:47:43, magjed_chromium wrote:
> > > > emircan - please take a look.
> > > > 
> > > > I ran all the H264 tests locally on my Mac, and they passed. Do you know
> if
> > > it's
> > > > possible to run the chromium.webrtc tests before landing?
> > > 
> > > I don't know of a way to run those before landing. Mac is usually reliable
> as
> > it
> > > is consistent with the local runs.
> > > 
> > > Do you remember what was the error that caused revert?
> > 
> > I remember I tried to investigate it a bit, but couldn't understand the
reason
> > for them failing. This CL will change some behavior, because we will start
> > negotiating and using other H264 profiles than baseline, and I'm not sure
that
> > code has been tested before.
> > 
> > I spoke with kjellander@ and it's indeed not possible to run the
> chromium.webrtc
> > bots as try jobs, but we might add that functionality.
> > 
> > Are you ok with landing this CL and see what happens? If it's still causing
> > problems I'll revert asap and try to reproduce locally.
> 
> Sounds good then. lgtm.
> 
> One more question. OpenH264 encoder has ConstrainedBaseline support and HW
> encoders only support Baseline right now. HW decoder doesn't receive profile
> info and defaults to Main support [0]. I see you aren't touching decode code
yet
> in this CL, but what is your plan there?
> 
> [0]
>
https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_dec...

That's a good question. I'll work on propagating the cricket::VideoCodec
containing the profile information to the decoder factory as well.

[magjed_chromium, 2017-07-07 08:31:11]

The CQ bit was checked by magjed@chromium.org

[commit-bot: I haz the power, 2017-07-07 08:31:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 10:17:48]

CQ is committing da patch.

Bot data: {"patchset_id": 190001, "attempt_start_ts": 1499416271547480,
"parent_rev": "9d84260fdb5d8600a123b461f228c830ab594bb4", "commit_rev":
"829b1d57525c3c6549d18a2c85a96527d59ea5e9"}

[commit-bot: I haz the power, 2017-07-07 10:18:01]

Description was changed from

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Try again.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959
==========

to

==========
Reland of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#1 id:1 of https://codereview.chromium.org/2521923002/ )

Reason for revert:
Try again.

Original issue's description:
> Revert of RTCVideoEncoder: Report H264 profile information to WebRTC (patchset
#3 id:60001 of https://codereview.chromium.org/2499973002/ )
> 
> Reason for revert:
> Causes these tests to fail on chromium.webrtc bots for Win and Mac:
>
WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
>
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264
>
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30367
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62661
> 
> Original issue's description:
> > RTCVideoEncoder: Report H264 profile information to WebRTC
> >
> > This CL updates RTCVideoEncoderFactory to report cricket::VideoCodecs
> > instead of WebRtcVideoEncoderFactory::VideoCodecs. The H264 profile
> > information is added to the cricket::VideoCodec so that WebRTC receives
> > this information. Also, the mapping between media::VideoCodecProfiles
> > and cricket::VideoCodecs is cached so that we can send the
> > media::VideoCodecProfile to RTCVideoEncoder instead of having to deal
> > with webrtc::VideoCodecType.
> >
> > BUG=webrtc:6337
> >
> > Committed: https://crrev.com/510eddede44cb4b67c8f17fdd68cefb780a668c5
> > Cr-Commit-Position: refs/heads/master@{#433508}
> 
> TBR=emircan@chromium.org,posciak@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6337
> 
> Committed: https://crrev.com/c2564bc627cb950b124ac8e41bc5fd3187f7ad9c
> Cr-Commit-Position: refs/heads/master@{#433828}

TBR=emircan@chromium.org,posciak@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688541,735959

Review-Url: https://codereview.chromium.org/2548443002
Cr-Commit-Position: refs/heads/master@{#484874}
Committed:
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...
==========

[commit-bot: I haz the power, 2017-07-07 10:18:03]

Committed patchset #1 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/829b1d57525c3c6549d18a2c85a9...

[Niklas Enbom, 2017-07-07 16:58:10]

A revert of this CL (patchset #1 id:190001) has been created in
https://codereview.chromium.org/2973253002/ by niklase@chromium.org.

The reason for reverting is: Reverting this since it's causing multiple perf
regression on mac, looks like HW encode/decode might get disabled..