Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298333003: DevTools: Implement console message logging through an extension (Closed)

Created:
6 years, 6 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
sergeyv, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Implement console message logging through an extension Due to the upcoming split of the "sdk" module, certain types will not be able to access ConsoleModel. As such, a specific message logging API should be exposed to all modules to use in place of direct WebInspector.console.log/showErrorMessage calls. R=sergeyv@chromium.org, yurys@chromium.org, pfeldman, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175061

Patch Set 1 : #

Patch Set 2 : Implement a common MessageSink #

Total comments: 10

Patch Set 3 : Address comments #

Patch Set 4 : More comments addressed #

Patch Set 5 : Remove duplicate logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -73 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/InspectorFrontendHostStub.js View 1 3 chunks +4 lines, -7 lines 0 comments Download
A Source/devtools/front_end/common/MessageSink.js View 1 1 chunk +79 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 4 chunks +47 lines, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 5 chunks +18 lines, -9 lines 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 chunks +16 lines, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileView.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotProxy.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 3 chunks +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/ConsoleModel.js View 1 2 3 5 chunks +12 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sdk/IsolatedFileSystemManager.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/LiveEditSupport.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sdk/SASSSourceMapping.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/StylesSourceMapping.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/TempFile.js View 1 7 chunks +9 lines, -16 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/UISourceCodeFrame.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
apavlov
6 years, 6 months ago (2014-05-28 11:28:57 UTC) #1
sergeyv
https://codereview.chromium.org/298333003/diff/40001/Source/devtools/front_end/sdk/ConsoleModel.js File Source/devtools/front_end/sdk/ConsoleModel.js (right): https://codereview.chromium.org/298333003/diff/40001/Source/devtools/front_end/sdk/ConsoleModel.js#newcode371 Source/devtools/front_end/sdk/ConsoleModel.js:371: WebInspector.ConsoleMessage.MessageLevel = { Why did you move it? https://codereview.chromium.org/298333003/diff/40001/Source/devtools/front_end/sdk/SASSSourceMapping.js ...
6 years, 6 months ago (2014-05-29 12:44:06 UTC) #2
apavlov
https://codereview.chromium.org/298333003/diff/40001/Source/devtools/front_end/sdk/ConsoleModel.js File Source/devtools/front_end/sdk/ConsoleModel.js (right): https://codereview.chromium.org/298333003/diff/40001/Source/devtools/front_end/sdk/ConsoleModel.js#newcode371 Source/devtools/front_end/sdk/ConsoleModel.js:371: WebInspector.ConsoleMessage.MessageLevel = { On 2014/05/29 12:44:06, sergeyv wrote: > ...
6 years, 6 months ago (2014-05-29 13:47:45 UTC) #3
sergeyv
lgtm
6 years, 6 months ago (2014-05-29 14:00:56 UTC) #4
yurys
lgtm
6 years, 6 months ago (2014-05-29 14:27:52 UTC) #5
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-05-29 14:41:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/298333003/100001
6 years, 6 months ago (2014-05-29 14:42:45 UTC) #7
apavlov
6 years, 6 months ago (2014-05-29 15:57:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 manually as r175061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698