Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove duplicate logging Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotView.js b/Source/devtools/front_end/profiler/HeapSnapshotView.js
index 143b6fb6e079e7b5b11500156f934e23b097b118..c8dc7be17e1f70e21fb9e72df73346bac160485a 100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotView.js
@@ -945,7 +945,7 @@ WebInspector.HeapSnapshotView.prototype = {
function didHighlightObject(found)
{
if (!found)
- WebInspector.console.log("Cannot find corresponding heap snapshot node", WebInspector.ConsoleMessage.MessageLevel.Error, true);
+ WebInspector.messageSink.addErrorMessage("Cannot find corresponding heap snapshot node", true);
}
},
@@ -1676,8 +1676,7 @@ WebInspector.HeapProfileHeader.prototype = {
if (!accepted)
return;
if (this._failedToCreateTempFile) {
- WebInspector.console.log("Failed to open temp file with heap snapshot",
- WebInspector.ConsoleMessage.MessageLevel.Error);
+ WebInspector.messageSink.addErrorMessage("Failed to open temp file with heap snapshot");
fileOutputStream.close();
} else if (this._tempFile) {
var delegate = new WebInspector.SaveSnapshotOutputStreamDelegate(this);
@@ -1799,8 +1798,7 @@ WebInspector.SaveSnapshotOutputStreamDelegate.prototype = {
*/
onError: function(reader, event)
{
- WebInspector.console.log("Failed to read heap snapshot from temp file: " + event.message,
- WebInspector.ConsoleMessage.MessageLevel.Error);
+ WebInspector.messageSink.addErrorMessage("Failed to read heap snapshot from temp file: " + event.message);
this.onTransferFinished();
}
}
« no previous file with comments | « Source/devtools/front_end/profiler/HeapSnapshotProxy.js ('k') | Source/devtools/front_end/profiler/ProfilesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698