Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: Source/devtools/front_end/InspectorFrontendHostStub.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove duplicate logging Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/common/MessageSink.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/InspectorFrontendHostStub.js
diff --git a/Source/devtools/front_end/InspectorFrontendHostStub.js b/Source/devtools/front_end/InspectorFrontendHostStub.js
index 577dd86e11ad38fb90450cc27038a3523555e85a..48e8944bc88863e0c094d939909b6edd209cd4ad 100644
--- a/Source/devtools/front_end/InspectorFrontendHostStub.js
+++ b/Source/devtools/front_end/InspectorFrontendHostStub.js
@@ -127,7 +127,7 @@ WebInspector.InspectorFrontendHostStub.prototype = {
copyText: function(text)
{
- WebInspector.console.log("Clipboard is not enabled in hosted mode. Please inspect using chrome://inspect", WebInspector.ConsoleMessage.MessageLevel.Error, true);
+ WebInspector.messageSink.addErrorMessage("Clipboard is not enabled in hosted mode. Please inspect using chrome://inspect", true);
},
openInNewTab: function(url)
@@ -137,13 +137,13 @@ WebInspector.InspectorFrontendHostStub.prototype = {
save: function(url, content, forceSaveAs)
{
- WebInspector.console.log("Saving files is not enabled in hosted mode. Please inspect using chrome://inspect", WebInspector.ConsoleMessage.MessageLevel.Error, true);
+ WebInspector.messageSink.addErrorMessage("Saving files is not enabled in hosted mode. Please inspect using chrome://inspect", true);
WebInspector.fileManager.canceledSaveURL(url);
},
append: function(url, content)
{
- WebInspector.console.log("Saving files is not enabled in hosted mode. Please inspect using chrome://inspect", WebInspector.ConsoleMessage.MessageLevel.Error, true);
+ WebInspector.messageSink.addErrorMessage("Saving files is not enabled in hosted mode. Please inspect using chrome://inspect", true);
},
sendMessageToBackend: function(message)
@@ -274,10 +274,7 @@ if (!window.InspectorFrontendHost) {
continue;
InspectorFrontendHost[name] = function(name) {
var message = "Incompatible embedder: method InspectorFrontendHost." + name + " is missing. Using stub instead.";
- if (WebInspector.console)
- WebInspector.console.showErrorMessage(message);
- else
- console.error(message);
+ WebInspector.messageSink.addErrorMessage(message, true);
var args = Array.prototype.slice.call(arguments, 1);
return proto[name].apply(InspectorFrontendHost, args);
}.bind(null, name);
« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/common/MessageSink.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698