Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1861)

Unified Diff: Source/devtools/front_end/sdk/LiveEditSupport.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove duplicate logging Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/LiveEditSupport.js
diff --git a/Source/devtools/front_end/sdk/LiveEditSupport.js b/Source/devtools/front_end/sdk/LiveEditSupport.js
index 539e01bbcc5040423cbeff99be466bf57e5ccb6f..1abd6c1e7d378d17621c9b43d97ed320be2da119 100644
--- a/Source/devtools/front_end/sdk/LiveEditSupport.js
+++ b/Source/devtools/front_end/sdk/LiveEditSupport.js
@@ -113,22 +113,22 @@ WebInspector.LiveEditSupport.logDetailedError = function(error, errorData, conte
var warningLevel = WebInspector.ConsoleMessage.MessageLevel.Warning;
if (!errorData) {
if (error)
- WebInspector.console.log(WebInspector.UIString("LiveEdit failed: %s", error), warningLevel, false);
+ WebInspector.messageSink.addMessage(WebInspector.UIString("LiveEdit failed: %s", error), warningLevel);
return;
}
var compileError = errorData.compileError;
if (compileError) {
var location = contextScript ? WebInspector.UIString(" at %s:%d:%d", contextScript.sourceURL, compileError.lineNumber, compileError.columnNumber) : "";
var message = WebInspector.UIString("LiveEdit compile failed: %s%s", compileError.message, location);
- WebInspector.console.log(message, WebInspector.ConsoleMessage.MessageLevel.Error, false);
+ WebInspector.messageSink.addErrorMessage(message);
} else {
- WebInspector.console.log(WebInspector.UIString("Unknown LiveEdit error: %s; %s", JSON.stringify(errorData), error), warningLevel, false);
+ WebInspector.messageSink.addMessage(WebInspector.UIString("Unknown LiveEdit error: %s; %s", JSON.stringify(errorData), error), warningLevel);
}
}
WebInspector.LiveEditSupport.logSuccess = function()
{
- WebInspector.console.log(WebInspector.UIString("Recompilation and update succeeded."), WebInspector.ConsoleMessage.MessageLevel.Debug, false);
+ WebInspector.messageSink.addMessage(WebInspector.UIString("Recompilation and update succeeded."));
}
/** @type {!WebInspector.LiveEditSupport} */
« no previous file with comments | « Source/devtools/front_end/sdk/IsolatedFileSystemManager.js ('k') | Source/devtools/front_end/sdk/SASSSourceMapping.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698