Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove duplicate logging Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index c5bef5d905f3cdcea7fd433741b4a0a239681e96..ee5c80bb4d07c9736b845afdf6253f8823493a39 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -1055,7 +1055,7 @@ WebInspector.TimelineModelLoader.prototype = {
try {
items = /** @type {!Array.<!TimelineAgent.TimelineEvent>} */ (JSON.parse(json));
} catch (e) {
- WebInspector.console.showErrorMessage("Malformed timeline data.");
+ WebInspector.messageSink.addErrorMessage("Malformed timeline data.", true);
this._model.reset();
this._reader.cancel();
this._progress.done();
@@ -1130,15 +1130,15 @@ WebInspector.TimelineModelLoadFromFileDelegate.prototype = {
this._model.reset();
switch (event.target.error.code) {
case FileError.NOT_FOUND_ERR:
- WebInspector.console.showErrorMessage(WebInspector.UIString("File \"%s\" not found.", reader.fileName()));
+ WebInspector.messageSink.addErrorMessage(WebInspector.UIString("File \"%s\" not found.", reader.fileName()), true);
break;
case FileError.NOT_READABLE_ERR:
- WebInspector.console.showErrorMessage(WebInspector.UIString("File \"%s\" is not readable", reader.fileName()));
+ WebInspector.messageSink.addErrorMessage(WebInspector.UIString("File \"%s\" is not readable", reader.fileName()), true);
break;
case FileError.ABORT_ERR:
break;
default:
- WebInspector.console.showErrorMessage(WebInspector.UIString("An error occurred while reading the file \"%s\"", reader.fileName()));
+ WebInspector.messageSink.addErrorMessage(WebInspector.UIString("An error occurred while reading the file \"%s\"", reader.fileName()), true);
}
}
}
« no previous file with comments | « Source/devtools/front_end/sources/UISourceCodeFrame.js ('k') | Source/devtools/scripts/frontend_modules.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698