Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2981173002: Remove the debugger_ field from Isolate in a PRODUCT build (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the debugger_ field from Isolate in a PRODUCT build. This is the first in a series of CL in which I am removing fields from classes that aren't used in PRODUCT mode. This CL removes the debugger_ field from Isolate. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/952345ff8424353e0f1ac2ea627e230a08071e07

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove flag support_debugger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -320 lines) Patch
M runtime/lib/async.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/lib/developer.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/lib/stacktrace.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M runtime/vm/compiler.cc View 1 3 chunks +30 lines, -33 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/flag_list.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 7 chunks +47 lines, -43 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/isolate.cc View 1 12 chunks +31 lines, -28 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +13 lines, -8 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +15 lines, -15 lines 0 comments Download
M runtime/vm/runtime_entry.cc View 1 5 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 8 chunks +38 lines, -34 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 8 chunks +38 lines, -34 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 7 chunks +36 lines, -31 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 7 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
3 years, 5 months ago (2017-07-18 16:56:32 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2981173002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/2981173002/diff/1/runtime/vm/object.cc#newcode5179 runtime/vm/object.cc:5179: if (!FLAG_support_debugger) { Consider removing FLAG_support_debugger since we ...
3 years, 5 months ago (2017-07-18 18:17:40 UTC) #4
zra
https://codereview.chromium.org/2981173002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/2981173002/diff/1/runtime/vm/object.cc#newcode5179 runtime/vm/object.cc:5179: if (!FLAG_support_debugger) { On 2017/07/18 18:17:40, rmacnak wrote: > ...
3 years, 5 months ago (2017-07-18 20:28:54 UTC) #5
zra
3 years, 5 months ago (2017-07-18 20:29:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
952345ff8424353e0f1ac2ea627e230a08071e07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698