Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: runtime/vm/parser.cc

Issue 2981173002: Remove the debugger_ field from Isolate in a PRODUCT build (Closed)
Patch Set: Remove flag support_debugger Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/runtime_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 3c9e08c61c7f59c295353de4a70a8076b334c2d1..2e7cc88e5f7220cadf539520357d49013f312970 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -9176,21 +9176,21 @@ AstNode* Parser::ParseAwaitForStatement(String* label_name) {
stream_expr_pos, new (Z) LoadLocalNode(stream_expr_pos, iterator_var),
Symbols::MoveNext(), no_args);
OpenBlock();
- if (FLAG_support_debugger) {
- // Call '_asyncStarMoveNextHelper' so that the debugger can intercept and
- // handle single stepping into a async* generator.
- const Function& async_star_move_next_helper = Function::ZoneHandle(
- Z, isolate()->object_store()->async_star_move_next_helper());
- ASSERT(!async_star_move_next_helper.IsNull());
- ArgumentListNode* async_star_move_next_helper_args =
- new (Z) ArgumentListNode(stream_expr_pos);
- async_star_move_next_helper_args->Add(
- new (Z) LoadLocalNode(stream_expr_pos, stream_var));
- StaticCallNode* async_star_move_next_helper_call =
- new (Z) StaticCallNode(stream_expr_pos, async_star_move_next_helper,
- async_star_move_next_helper_args);
- current_block_->statements->Add(async_star_move_next_helper_call);
- }
+#if !defined(PRODUCT)
+ // Call '_asyncStarMoveNextHelper' so that the debugger can intercept and
+ // handle single stepping into a async* generator.
+ const Function& async_star_move_next_helper = Function::ZoneHandle(
+ Z, isolate()->object_store()->async_star_move_next_helper());
+ ASSERT(!async_star_move_next_helper.IsNull());
+ ArgumentListNode* async_star_move_next_helper_args =
+ new (Z) ArgumentListNode(stream_expr_pos);
+ async_star_move_next_helper_args->Add(
+ new (Z) LoadLocalNode(stream_expr_pos, stream_var));
+ StaticCallNode* async_star_move_next_helper_call =
+ new (Z) StaticCallNode(stream_expr_pos, async_star_move_next_helper,
+ async_star_move_next_helper_args);
+ current_block_->statements->Add(async_star_move_next_helper_call);
+#endif
AstNode* await_moveNext = new (Z) AwaitNode(
stream_expr_pos, iterator_moveNext, saved_try_ctx, async_saved_try_ctx,
outer_saved_try_ctx, outer_async_saved_try_ctx, current_block_->scope);
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/runtime_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698