Remove the debugger_ field from Isolate in a PRODUCT build

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 
 #include "vm/ast_printer.h"
 #include "vm/block_scheduler.h"
@@ skipping 214 matching lines @@
   if (result.IsError()) {
     if (result.IsLanguageError()) {
       Exceptions::ThrowCompileTimeError(LanguageError::Cast(result));
       UNREACHABLE();
     }
     Exceptions::PropagateError(Error::Cast(result));
   }
 }
 
 bool Compiler::CanOptimizeFunction(Thread* thread, const Function& function) {
-  if (FLAG_support_debugger) {
-    Isolate* isolate = thread->isolate();
-    if (isolate->debugger()->IsStepping() ||
-        isolate->debugger()->HasBreakpoint(function, thread->zone())) {
-      // We cannot set breakpoints and single step in optimized code,
-      // so do not optimize the function.
-      function.set_usage_counter(0);
-      return false;
-    }
+#if !defined(PRODUCT)
+  Isolate* isolate = thread->isolate();
+  if (isolate->debugger()->IsStepping() ||
+      isolate->debugger()->HasBreakpoint(function, thread->zone())) {
+    // We cannot set breakpoints and single step in optimized code,
+    // so do not optimize the function.
+    function.set_usage_counter(0);
+    return false;
   }
+#endif
   if (function.deoptimization_counter() >=
       FLAG_max_deoptimization_counter_threshold) {
     if (FLAG_trace_failed_optimization_attempts ||
         FLAG_stop_on_excessive_deoptimization) {
       THR_Print("Too many deoptimizations: %s\n",
                 function.ToFullyQualifiedCString());
       if (FLAG_stop_on_excessive_deoptimization) {
         FATAL("Stop on excessive deoptimization");
       }
     }
@@ skipping 292 matching lines @@
       Array::Handle(zone, graph_compiler->CreateDeoptInfo(assembler));
   INC_STAT(thread(), total_code_size,
            deopt_info_array.Length() * sizeof(uword));
   // Allocates instruction object. Since this occurs only at safepoint,
   // there can be no concurrent access to the instruction page.
   Code& code =
       Code::Handle(Code::FinalizeCode(function, assembler, optimized()));
   code.set_is_optimized(optimized());
   code.set_owner(function);
 #if !defined(PRODUCT)
-  if (FLAG_support_debugger) {
-    ZoneGrowableArray<TokenPosition>* await_token_positions =
-        flow_graph->await_token_positions();
-    if (await_token_positions != NULL) {
-      Smi& token_pos_value = Smi::Handle(zone);
-      if (await_token_positions->length() > 0) {
-        const Array& await_to_token_map = Array::Handle(
-            zone, Array::New(await_token_positions->length(), Heap::kOld));
-        ASSERT(!await_to_token_map.IsNull());
-        for (intptr_t i = 0; i < await_token_positions->length(); i++) {
-          TokenPosition token_pos =
-              await_token_positions->At(i).FromSynthetic();
-          if (!token_pos.IsReal()) {
-            // Some async machinary uses sentinel values. Map them to
-            // no source position.
-            token_pos_value = Smi::New(TokenPosition::kNoSourcePos);
-          } else {
-            token_pos_value = Smi::New(token_pos.value());
-          }
-          await_to_token_map.SetAt(i, token_pos_value);
+  ZoneGrowableArray<TokenPosition>* await_token_positions =
+      flow_graph->await_token_positions();
+  if (await_token_positions != NULL) {
+    Smi& token_pos_value = Smi::Handle(zone);
+    if (await_token_positions->length() > 0) {
+      const Array& await_to_token_map = Array::Handle(
+          zone, Array::New(await_token_positions->length(), Heap::kOld));
+      ASSERT(!await_to_token_map.IsNull());
+      for (intptr_t i = 0; i < await_token_positions->length(); i++) {
+        TokenPosition token_pos = await_token_positions->At(i).FromSynthetic();
+        if (!token_pos.IsReal()) {
+          // Some async machinary uses sentinel values. Map them to
+          // no source position.
+          token_pos_value = Smi::New(TokenPosition::kNoSourcePos);
+        } else {
+          token_pos_value = Smi::New(token_pos.value());
         }
-        code.set_await_token_positions(await_to_token_map);
+        await_to_token_map.SetAt(i, token_pos_value);
       }
+      code.set_await_token_positions(await_to_token_map);
     }
   }
 #endif  // !defined(PRODUCT)
 
   if (!function.IsOptimizable()) {
     // A function with huge unoptimized code can become non-optimizable
     // after generating unoptimized code.
     function.set_usage_counter(INT_MIN);
   }
 
@@ skipping 753 matching lines @@
     per_compile_timer.Stop();
 
     if (trace_compiler) {
       THR_Print("--> '%s' entry: %#" Px " size: %" Pd " time: %" Pd64 " us\n",
                 function.ToFullyQualifiedCString(),
                 Code::Handle(function.CurrentCode()).PayloadStart(),
                 Code::Handle(function.CurrentCode()).Size(),
                 per_compile_timer.TotalElapsedTime());
     }
 
-    if (FLAG_support_debugger) {
-      isolate->debugger()->NotifyCompilation(function);
-    }
+#if !defined(PRODUCT)
+    isolate->debugger()->NotifyCompilation(function);
+#endif
 
     if (FLAG_disassemble && FlowGraphPrinter::ShouldPrint(function)) {
       Disassembler::DisassembleCode(function, result, optimized);
     } else if (FLAG_disassemble_optimized && optimized &&
                FlowGraphPrinter::ShouldPrint(function)) {
       Disassembler::DisassembleCode(function, result, true);
     }
 
     return result.raw();
   } else {
@@ skipping 919 matching lines @@
 }
 
 bool BackgroundCompiler::IsDisabled() {
   UNREACHABLE();
   return true;
 }
 
 #endif  // DART_PRECOMPILED_RUNTIME
 
 }  // namespace dart