Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: runtime/vm/isolate.h

Issue 2981173002: Remove the debugger_ field from Isolate in a PRODUCT build (Closed)
Patch Set: Remove flag support_debugger Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index e5b1849d6999df4c3956dc5d275fd7fd6ee3ba6a..6afe1b2f2c85ea76c8617e30083f10727fd0dfa2 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -319,13 +319,12 @@ class Isolate : public BaseIsolate {
}
Mutex* megamorphic_lookup_mutex() const { return megamorphic_lookup_mutex_; }
+#if !defined(PRODUCT)
Debugger* debugger() const {
- if (!FLAG_support_debugger) {
- return NULL;
- }
ASSERT(debugger_ != NULL);
return debugger_;
}
+#endif
void set_single_step(bool value) { single_step_ = value; }
bool single_step() const { return single_step_; }
@@ -766,7 +765,7 @@ class Isolate : public BaseIsolate {
Dart_EnvironmentCallback environment_callback_;
Dart_LibraryTagHandler library_tag_handler_;
ApiState* api_state_;
- Debugger* debugger_;
+ NOT_IN_PRODUCT(Debugger* debugger_);
bool resume_request_;
int64_t last_resume_timestamp_;
Random random_;
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698