Remove the debugger_ field from Isolate in a PRODUCT build

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/become.h"
@@ skipping 5155 matching lines @@
 
 void PatchClass::set_script(const Script& value) const {
   StorePointer(&raw_ptr()->script_, value.raw());
 }
 
 intptr_t Function::Hash() const {
   return String::HashRawSymbol(name());
 }
 
 bool Function::HasBreakpoint() const {
+#if defined(PRODUCT)
+  return false;
+#else
   if (!FLAG_support_debugger) {

[rmacnak, 2017/07/18 18:17:40]

Consider removing FLAG_support_debugger since we now have `ifndef PRODUCT` 
guarding all its uses.

[zra, 2017/07/18 20:28:54]

Done.

     return false;
   }
   Thread* thread = Thread::Current();
   return thread->isolate()->debugger()->HasBreakpoint(*this, thread->zone());
+#endif
 }
 
 void Function::InstallOptimizedCode(const Code& code) const {
   DEBUG_ASSERT(IsMutatorOrAtSafepoint());
   // We may not have previous code if FLAG_precompile is set.
   // Hot-reload may have already disabled the current code.
   if (HasCode() && !Code::Handle(CurrentCode()).IsDisabled()) {
     Code::Handle(CurrentCode()).DisableDartCode();
   }
   AttachCode(code);
@@ skipping 760 matching lines @@
 void Function::SetIsOptimizable(bool value) const {
   ASSERT(!is_native());
   set_is_optimizable(value);
   if (!value) {
     set_is_inlinable(false);
     set_usage_counter(INT_MIN);
   }
 }
 
 bool Function::CanBeInlined() const {
+#if defined(PRODUCT)
+  return is_inlinable() && !is_external() && !is_generated_body();
+#else
   Thread* thread = Thread::Current();
   return is_inlinable() && !is_external() && !is_generated_body() &&
          (!FLAG_support_debugger ||
           !thread->isolate()->debugger()->HasBreakpoint(*this, thread->zone()));
+#endif
 }
 
 intptr_t Function::NumParameters() const {
   return num_fixed_parameters() + NumOptionalParameters();
 }
 
 intptr_t Function::NumImplicitParameters() const {
   if (kind() == RawFunction::kConstructor) {
     // Type arguments for factory; instance for generative constructor.
     return 1;
@@ skipping 7606 matching lines @@
   // emitting assembly. This guarantees that every succeeding pc-offset is
   // larger than the previously added one.
   for (intptr_t i = kSCallTableEntryLength; i < value.Length();
        i += kSCallTableEntryLength) {
     ASSERT(value.At(i - kSCallTableEntryLength) < value.At(i));
   }
 #endif  // DEBUG
 }
 
 bool Code::HasBreakpoint() const {
+#if defined(PRODUCT)
+  return false;
+#else
   if (!FLAG_support_debugger) {
     return false;
   }
   return Isolate::Current()->debugger()->HasBreakpoint(*this);
+#endif
 }
 
 RawTypedData* Code::GetDeoptInfoAtPc(uword pc,
                                      ICData::DeoptReasonId* deopt_reason,
                                      uint32_t* deopt_flags) const {
 #if defined(DART_PRECOMPILED_RUNTIME)
   ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
   return TypedData::null();
 #else
   ASSERT(is_optimized());
@@ skipping 8627 matching lines @@
   }
   return UserTag::null();
 }
 
 const char* UserTag::ToCString() const {
   const String& tag_label = String::Handle(label());
   return tag_label.ToCString();
 }
 
 }  // namespace dart