Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 297263003: Optimize promotion of ephemeral apps (Closed)

Created:
6 years, 7 months ago by tmdiep
Modified:
6 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Optimize promotion of ephemeral apps Introduces ExtensionService::PromoteEphemeralApp(), which allows an ephemeral app to be quickly promoted to a regular installed app. This is called when installing from the app launcher, Web Store detail page, "Install app" item in the ephemeral app's shelf menu, or from sync. BUG=374018 TEST=browser_tests (EphemeralAppBrowserTest.*) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273206

Patch Set 1 #

Total comments: 24

Patch Set 2 : Addressed review comments and added more tests #

Total comments: 1

Patch Set 3 : Nits #

Patch Set 4 : Use ScopedObserver #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -158 lines) Patch
A chrome/browser/apps/ephemeral_app_browsertest.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.cc View 1 2 3 15 chunks +426 lines, -110 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/shortcut_manager.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/shortcut_manager.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 5 chunks +28 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 5 chunks +76 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 1 2 3 4 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/extensions/install_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 1 2 chunks +20 lines, -17 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_prefs.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 3 chunks +16 lines, -4 lines 0 comments Download
M extensions/browser/extension_registry.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_registry.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M extensions/browser/extension_registry_observer.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/browser/extension_registry_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/common/extension.h View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/extension.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
tmdiep
This patch contains the core changes for quickly installing ephemeral apps. Best to review extension_service ...
6 years, 7 months ago (2014-05-25 23:10:38 UTC) #1
benwells
https://codereview.chromium.org/297263003/diff/1/chrome/browser/apps/ephemeral_app_browsertest.cc File chrome/browser/apps/ephemeral_app_browsertest.cc (right): https://codereview.chromium.org/297263003/diff/1/chrome/browser/apps/ephemeral_app_browsertest.cc#newcode160 chrome/browser/apps/ephemeral_app_browsertest.cc:160: InstallEphemeralAppWithSourceAndFlags( Is this git cl format? Looks like this ...
6 years, 7 months ago (2014-05-27 01:42:56 UTC) #2
tmdiep
Just answers to the questions. https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc#newcode2020 chrome/browser/extensions/extension_service.cc:2020: if (extension->RequiresSortOrdinal()) { On ...
6 years, 7 months ago (2014-05-27 01:58:54 UTC) #3
benwells
https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc#newcode2020 chrome/browser/extensions/extension_service.cc:2020: if (extension->RequiresSortOrdinal()) { On 2014/05/27 01:58:54, tmdiep wrote: > ...
6 years, 7 months ago (2014-05-27 03:11:10 UTC) #4
tmdiep
https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc#newcode2020 chrome/browser/extensions/extension_service.cc:2020: if (extension->RequiresSortOrdinal()) { On 2014/05/27 03:11:11, benwells wrote: > ...
6 years, 7 months ago (2014-05-27 03:21:53 UTC) #5
benwells
On 2014/05/27 03:21:53, tmdiep wrote: > https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc > File chrome/browser/extensions/extension_service.cc (right): > > https://codereview.chromium.org/297263003/diff/1/chrome/browser/extensions/extension_service.cc#newcode2020 > ...
6 years, 7 months ago (2014-05-27 03:30:22 UTC) #6
tmdiep
Ok all review comments addressed, hopefully I haven't missed anything. https://codereview.chromium.org/297263003/diff/1/chrome/browser/apps/ephemeral_app_browsertest.cc File chrome/browser/apps/ephemeral_app_browsertest.cc (right): https://codereview.chromium.org/297263003/diff/1/chrome/browser/apps/ephemeral_app_browsertest.cc#newcode160 ...
6 years, 7 months ago (2014-05-27 07:46:04 UTC) #7
benwells
nice tests! lgtm++ https://codereview.chromium.org/297263003/diff/20001/extensions/browser/extension_registry_observer.h File extensions/browser/extension_registry_observer.h (right): https://codereview.chromium.org/297263003/diff/20001/extensions/browser/extension_registry_observer.h#newcode53 extensions/browser/extension_registry_observer.h:53: // and |old_name| will be removed ...
6 years, 7 months ago (2014-05-27 22:18:27 UTC) #8
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 7 months ago (2014-05-28 01:38:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/297263003/60001
6 years, 7 months ago (2014-05-28 01:40:07 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 02:53:21 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 03:25:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/9774)
6 years, 7 months ago (2014-05-28 03:25:55 UTC) #13
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 7 months ago (2014-05-28 04:00:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/297263003/80001
6 years, 7 months ago (2014-05-28 04:00:48 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 05:56:34 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 05:56:34 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 05:57:00 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 13:52:04 UTC) #19
Message was sent while issue was closed.
Change committed as 273206

Powered by Google App Engine
This is Rietveld 408576698