Optimize promotion of ephemeral apps

extensions/browser/extension_registry.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_REGISTRY_H_
 #define EXTENSIONS_BROWSER_EXTENSION_REGISTRY_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 60 matching lines @@
 
   // Invokes the observer method OnExtensionUnloaded(). The extension must not
   // be enabled at the time of the call.
   void TriggerOnUnloaded(const Extension* extension,
                          UnloadedExtensionInfo::Reason reason);
 
   // If this is a fresh install then |is_update| is false and there must not be
   // any installed extension with |extension|'s ID. If this is an update then
   // |is_update| is true and must be an installed extension with |extension|'s
   // ID, and |old_name| must be non-empty.
+  // If true, |from_ephemeral| indicates that the extension was previously
+  // installed ephemerally and has been promoted to a regular installed
+  // extension. |is_update| should also be true.

[benwells, 2014/05/27 01:42:56]

Please add a TODO to remove these historical parameters.

[tmdiep, 2014/05/27 07:46:05]

Done.

   void TriggerOnWillBeInstalled(const Extension* extension,
                                 bool is_update,
+                                bool from_ephemeral,
                                 const std::string& old_name);
 
   // Invokes the observer method OnExtensionUninstalled(). The extension must
   // not be any installed extension with |extension|'s ID.
   void TriggerOnUninstalled(const Extension* extension);
 
   // Find an extension by ID using |include_mask| to pick the sets to search:
   //  * enabled_extensions()     --> ExtensionRegistry::ENABLED
   //  * disabled_extensions()    --> ExtensionRegistry::DISABLED
   //  * terminated_extensions()  --> ExtensionRegistry::TERMINATED
@@ skipping 58 matching lines @@
   ObserverList<ExtensionRegistryObserver> observers_;
 
   content::BrowserContext* const browser_context_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionRegistry);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_REGISTRY_H_