Optimize promotion of ephemeral apps

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 273 matching lines @@
   void MaybeFinishDelayedInstallations();
 
   // Similar to FinishInstallation, but first checks if there still is an update
   // pending for the extension, and makes sure the extension is still idle.
   void MaybeFinishDelayedInstallation(const std::string& extension_id);
 
   // Finishes installation of an update for an extension with the specified id,
   // when installation of that extension was previously delayed because the
   // extension was in use.
   virtual void FinishDelayedInstallation(
-     const std::string& extension_id) OVERRIDE;
+      const std::string& extension_id) OVERRIDE;
+
+  // Promotes an ephemeral app to being installed permanently. Ephemeral apps
+  // are already installed in extension system (albiet transiently) and only
+  // need to be exposed in the UI. Set |user_acknowledged| to true if the
+  // install was confirmed via a dialog, otherwise set to false (for example,
+  // if the install was initiated via sync).
+  void InstallEphemeralApp(
+      const extensions::Extension* extension, bool user_acknowledged);

[benwells, 2014/05/27 01:42:56]

Can this be InstallEphemeralAppPermanently? The name alone could be interpreted
differently.

[tmdiep, 2014/05/27 01:58:54]

Yeah, I originally had "InstallEphemeralAppPermanently", but then thought it's
not literally permanent - it can still be uninstalled. Depends on how literally
people will take it.

[tmdiep, 2014/05/27 07:46:05]

Changed to PromoteEphemeralApp, and user_acknowledged to is_from_sync

 
   // Returns an update for an extension with the specified id, if installation
   // of that update was previously delayed because the extension was in use. If
   // no updates are pending for the extension returns NULL.
   virtual const extensions::Extension* GetPendingExtensionUpdate(
       const std::string& extension_id) const OVERRIDE;
 
   // Go through each extension and unload those that are not allowed to run by
   // management policy providers (ie. network admin and Google-managed
   // blacklist).
@@ skipping 117 matching lines @@
   // doesn't notify the user that the extension was terminated, if such a
   // notification is desired the calling code is responsible for doing that.
   void TerminateExtension(const std::string& extension_id);
 
 #if defined(UNIT_TEST)
   void TrackTerminatedExtensionForTest(const extensions::Extension* extension) {
     TrackTerminatedExtension(extension);
   }
 
   void FinishInstallationForTest(const extensions::Extension* extension) {
-    FinishInstallation(extension);
+    FinishInstallation(extension, false);
   }
 #endif
 
   base::WeakPtr<ExtensionService> AsWeakPtr() { return base::AsWeakPtr(this); }
 
   bool browser_terminating() const { return browser_terminating_; }
 
   extensions::SharedModuleService* shared_module_service() {
     return shared_module_service_.get();
   }
@@ skipping 52 matching lines @@
 
   // Handles sending notification that |extension| was loaded.
   void NotifyExtensionLoaded(const extensions::Extension* extension);
 
   // Handles sending notification that |extension| was unloaded.
   void NotifyExtensionUnloaded(
       const extensions::Extension* extension,
       extensions::UnloadedExtensionInfo::Reason reason);
 
   // Common helper to finish installing the given extension.
-  void FinishInstallation(const extensions::Extension* extension);
+  void FinishInstallation(const extensions::Extension* extension,
+                          bool was_ephemeral);

[benwells, 2014/05/27 01:42:56]

What is |was_ephemeral| if it wasn't installed at all before?

[tmdiep, 2014/05/27 01:58:54]

It should be false. I'll add a comment.

 
   // Updates the |extension|'s active permission set to include only permissions
   // currently requested by the extension and all the permissions required by
   // the extension.
   void UpdateActivePermissions(const extensions::Extension* extension);
 
   // Disables the extension if the privilege level has increased
   // (e.g., due to an upgrade).
   void CheckPermissionsIncrease(const extensions::Extension* extension,
                                 bool is_extension_installed);
@@ skipping 186 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistDontEnableManuallyDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistUnknownDontChange);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_