Optimize promotion of ephemeral apps

extensions/browser/extension_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 462 matching lines @@
   // if no such evicted app exists or is currently installed.
   scoped_ptr<ExtensionInfo> GetEvictedEphemeralAppInfo(
       const std::string& extension_id) const;
 
   // Permanently remove the preferences for an evicted ephemeral app.
   void RemoveEvictedEphemeralApp(const std::string& extension_id);
 
   // Returns true if the extension is an ephemeral app.
   bool IsEphemeralApp(const std::string& extension_id) const;
 
+  // Promotes an ephemeral app to a regular installed app.
+  void OnEphemeralAppInstalled(const std::string& extension_id);

[benwells, 2014/05/27 01:42:56]

Same here, the name alone is confusing. Suggest
OnEphemeralAppInstalledPermanently.

[tmdiep, 2014/05/27 01:58:54]

Yeah, this was the original name as well. What about "OnEphemeralAppPromoted",
or is this even more confusing??

[benwells, 2014/05/27 03:11:11]

sgtm.

[tmdiep, 2014/05/27 07:46:05]

Done.

+
   // Returns true if the user repositioned the app on the app launcher via drag
   // and drop.
   bool WasAppDraggedByUser(const std::string& extension_id);
 
   // Sets a flag indicating that the user repositioned the app on the app
   // launcher by drag and dropping it.
   void SetAppDraggedByUser(const std::string& extension_id);
 
   // Returns true if there is an extension which controls the preference value
   //  for |pref_key| *and* it is specific to incognito mode.
@@ skipping 228 matching lines @@
   bool extensions_disabled_;
 
   ObserverList<ExtensionPrefsObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_