Create start menu shortcut when an ephemeral app is promoted

Create start menu shortcut when an ephemeral app is promoted

Start menu shortcuts are created during the installation process for 
regular apps, but not ephemeral apps. This patch ensures that shortcuts 
are created when ephemeral apps are promoted to regular installed apps. 

This patch also adds a check to exclude extensions before creating or 
updating shortcuts. 

BUG=374018
TEST=Launch an app ephemerally and verify that start menu shortcuts 
have not been added. Install the app and verify that shortcuts are
added.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273274

[tmdiep, 2014-05-28 05:13:34]

A small patch for a change :) Follows https://codereview.chromium.org/297263003.

I couldn't find an easy way to write a test for this.

https://codereview.chromium.org/300623004/diff/40001/chrome/browser/apps/shor...
File chrome/browser/apps/shortcut_manager.cc (right):

https://codereview.chromium.org/300623004/diff/40001/chrome/browser/apps/shor...
chrome/browser/apps/shortcut_manager.cc:112: if (!extension->is_app())
Added optimization here to avoid scanning for shortcuts when extensions are
updated. This change should not break crbug.com/353454.

[benwells, 2014-05-28 06:26:17]

lgtm

[tmdiep, 2014-05-28 14:49:12]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:51:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/300623004/40001

[commit-bot: I haz the power, 2014-05-28 16:48:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[commit-bot: I haz the power, 2014-05-28 16:58:14]

Change committed as 273274