Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

content/renderer/media/media_stream_video_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_STREAM_VIDEO_SOURCE_H_
 #define CONTENT_RENDERER_MEDIA_MEDIA_STREAM_VIDEO_SOURCE_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 19 matching lines @@
 class VideoTrackAdapter;
 struct VideoTrackAdapterSettings;
 
 // MediaStreamVideoSource is an interface used for sending video frames to a
 // MediaStreamVideoTrack.
 // http://dev.w3.org/2011/webrtc/editor/getusermedia.html
 // The purpose of this base class is to be able to implement different
 // MediaStreaVideoSources such as local video capture, video sources received
 // on a PeerConnection or a source created in NaCl.
 // All methods calls will be done from the main render thread.
-//
-// When the first track is added to the source by calling AddTrack, the
-// MediaStreamVideoSource implementation calls GetCurrentSupportedFormats.
-// The source implementation must call OnSupportedFormats.
-// MediaStreamVideoSource then match the constraints provided in AddTrack with
-// the formats and call StartSourceImpl. The source implementation must call
-// OnStartDone when the underlying source has been started or failed to start.

[hbos_chromium, 2017/07/04 14:06:34]

OnStartDone is still used, was too much of this comment removed or should it be
rewritten?

[Guido Urdaneta, 2017/07/04 14:30:28]

I intentionally removed the part about OnStartDone since it's to detailed for a
class comment.

The StartSourceImpl() comment mentions the bit about OnStartDone.

 class CONTENT_EXPORT MediaStreamVideoSource : public MediaStreamSource {
  public:
   enum {
     // Default resolution. If no constraints are specified and the delegate
     // support it, this is the resolution that will be used.
     kDefaultWidth = 640,
     kDefaultHeight = 480,
 
     kDefaultFrameRate = 30,
     kUnknownFrameRate = 0,
@@ skipping 36 matching lines @@
 
  protected:
   void DoStopSource() override;
 
   // Sets ready state and notifies the ready state to all registered tracks.
   virtual void SetReadyState(blink::WebMediaStreamSource::ReadyState state);
 
   // Sets muted state and notifies it to all registered tracks.
   virtual void SetMutedState(bool state);
 
-  // An implementation must fetch the formats that can currently be used by
-  // the source and call OnSupportedFormats when done.
-  // |max_requested_height| and |max_requested_width| is the max height and
-  // width set as a mandatory constraint if set when calling
-  // MediaStreamVideoSource::AddTrack. If max height and max width is not set
-  // |max_requested_height| and |max_requested_width| are 0.
-  // TODO(guidou): Remove when the standard constraints code stabilizes.
-  // http://crbug.com/706408
-  virtual void GetCurrentSupportedFormats(
-      int max_requested_width,
-      int max_requested_height,
-      double max_requested_frame_rate,
-      const VideoCaptureDeviceFormatsCB& callback) = 0;
-
   // TODO(guidou): Rename to GetCurrentFormat. http://crbug.com/706804
   virtual base::Optional<media::VideoCaptureFormat> GetCurrentFormatImpl()
       const;
 
   // An implementation must start capturing frames using the requested
   // |format|. The fulfilled |constraints| are provided as additional context,
   // and may be used to modify the behavior of the source. When the source has
   // started or the source failed to start OnStartDone must be called. An
   // implementation must call |frame_callback| on the IO thread with the
   // captured frames.
@@ skipping 75 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<MediaStreamVideoSource> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaStreamVideoSource);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_MEDIA_STREAM_VIDEO_SOURCE_H_