Remove support for old getUserMedia video constraints algorithm.

Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks now and
having the option to switch back to the old algorithm is no longer
necessary.

BUG=706408
Review-Url: https://codereview.chromium.org/2964003002
Cr-Commit-Position: refs/heads/master@{#484202}
Committed: https://chromium.googlesource.com/chromium/src/+/6beb0cec0f47293fc637421c85e275a657caf7e7

[Guido Urdaneta, 2017-06-29 14:02:14]

Description was changed from

==========
Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks and having
the option to switch back to the old algorithm is not necessary.

BUG=706408
==========

to

==========
Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks and having
the option to switch back to the old algorithm is not necessary.

BUG=706408
==========

[Guido Urdaneta, 2017-06-29 14:15:33]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2017-06-29 14:20:29]

Patchset #1 (id:20001) has been deleted

[Guido Urdaneta, 2017-06-29 14:27:06]

guidou@chromium.org changed reviewers:
+ tommi@chromium.org

[Guido Urdaneta, 2017-06-29 14:27:37]

Description was changed from

==========
Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks and having
the option to switch back to the old algorithm is not necessary.

BUG=706408
==========

to

==========
Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks now and
having the option to switch back to the old algorithm is no longer
necessary.

BUG=706408
==========

[Guido Urdaneta, 2017-06-29 14:28:03]

guidou@chromium.org changed reviewers:
+ miu@chromium.org
- tommi@chromium.org

[Guido Urdaneta, 2017-06-29 14:30:45]

Hi, PTAL

[Guido Urdaneta, 2017-06-29 14:34:23]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 14:34:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 15:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 15:48:58]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-06-30 14:18:55]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org
- miu@chromium.org

[Guido Urdaneta, 2017-06-30 14:19:54]

hbos@: since you're back, can you take a look?

Moving miu@ to cc

[hbos_chromium, 2017-06-30 15:04:12]

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_capturer_source.cc (right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source.cc:31: const char
kPowerLineFrequency[] = "googPowerLineFrequency";
Power line: remove this?

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source.cc:249: }
Power line: remove this?

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_capturer_source.h (right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source.h:70: const char*
GetPowerLineFrequencyForTesting() const;
Power line: remove this?

I think this is not used anymore. AFAIK it is only used by a
GetPowerLineFrequencyForTesting function in the unittest which isn't used?

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_capturer_source_unittest.cc
(right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source_unittest.cc:154: }
Power line: remove this?

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_source.h (right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_source.h:42: // MediaStreamVideoSource
implementation calls GetCurrentSupportedFormats.
Update comment after removing GetCurrentSupportedFormats.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_source.h:115: const
VideoCaptureDeviceFormatsCB& callback) = 0;
This was only used by AddTrackLegacy; remove it.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_source.h:190:
media::VideoCaptureFormats supported_formats_;
Remove, I don't think it's used anymore now that RETRIEVING_CAPABILITIES /
OnSupportedFormats is gone.

[Guido Urdaneta, 2017-07-03 17:57:24]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 17:57:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-07-03 18:43:16]

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_capturer_source.cc (right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source.cc:31: const char
kPowerLineFrequency[] = "googPowerLineFrequency";
On 2017/06/30 15:04:12, hbos_chromium wrote:
> Power line: remove this?

Done.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source.cc:249: }
On 2017/06/30 15:04:12, hbos_chromium wrote:
> Power line: remove this?

Done.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_capturer_source.h (right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source.h:70: const char*
GetPowerLineFrequencyForTesting() const;
On 2017/06/30 15:04:12, hbos_chromium wrote:
> Power line: remove this?
> 
> I think this is not used anymore. AFAIK it is only used by a
> GetPowerLineFrequencyForTesting function in the unittest which isn't used?

Done.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_capturer_source_unittest.cc
(right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_capturer_source_unittest.cc:154: }
On 2017/06/30 15:04:12, hbos_chromium wrote:
> Power line: remove this?

Done.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_source.h (right):

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_source.h:42: // MediaStreamVideoSource
implementation calls GetCurrentSupportedFormats.
On 2017/06/30 15:04:12, hbos_chromium wrote:
> Update comment after removing GetCurrentSupportedFormats.

Acknowledged. Will do in follow-up CL.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_source.h:115: const
VideoCaptureDeviceFormatsCB& callback) = 0;
On 2017/06/30 15:04:12, hbos_chromium wrote:
> This was only used by AddTrackLegacy; remove it.

Will remove it in a follow-up CL together with other interface changes.

https://codereview.chromium.org/2964003002/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_source.h:190:
media::VideoCaptureFormats supported_formats_;
On 2017/06/30 15:04:12, hbos_chromium wrote:
> Remove, I don't think it's used anymore now that RETRIEVING_CAPABILITIES /
> OnSupportedFormats is gone.

Done.

[commit-bot: I haz the power, 2017-07-03 19:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 19:15:48]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2017-07-04 13:55:57]

lgtm

[Guido Urdaneta, 2017-07-04 14:16:17]

guidou@chromium.org changed reviewers:
+ kinuko@chromium.org

[Guido Urdaneta, 2017-07-04 14:16:18]

kinuko@chromium.org: can you rs content/public ?

[kinuko, 2017-07-05 02:45:56]

lgtm

[Guido Urdaneta, 2017-07-05 05:57:12]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-07-05 05:57:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 06:57:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499234232074890,
"parent_rev": "afee587152a3f0355bca8705827f16bfda0e4d0c", "commit_rev":
"6beb0cec0f47293fc637421c85e275a657caf7e7"}

[commit-bot: I haz the power, 2017-07-05 06:58:10]

Description was changed from

==========
Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks now and
having the option to switch back to the old algorithm is no longer
necessary.

BUG=706408
==========

to

==========
Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks now and
having the option to switch back to the old algorithm is no longer
necessary.

BUG=706408

Review-Url: https://codereview.chromium.org/2964003002
Cr-Commit-Position: refs/heads/master@{#484202}
Committed:
https://chromium.googlesource.com/chromium/src/+/6beb0cec0f47293fc637421c85e2...
==========

[commit-bot: I haz the power, 2017-07-05 06:58:11]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6beb0cec0f47293fc637421c85e2...