Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2972113002: Remove ScopedVector from tools/gn/. (Closed)

Created:
3 years, 5 months ago by Avi (use Gerrit)
Modified:
3 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from tools/gn/. BUG=554289 Review-Url: https://codereview.chromium.org/2972113002 Cr-Commit-Position: refs/heads/master@{#484744} Committed: https://chromium.googlesource.com/chromium/src/+/f6016b060cb2133958b6903a527f637adddf31b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M tools/gn/function_get_target_outputs.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_get_target_outputs_unittest.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M tools/gn/function_toolchain.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/functions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/loader.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/gn/scope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/target_generator.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Avi (use Gerrit)
PTAL; thanks!
3 years, 5 months ago (2017-07-06 21:14:27 UTC) #7
Avi (use Gerrit)
PTAL; thanks!
3 years, 5 months ago (2017-07-06 21:14:28 UTC) #8
brettw
lgtm
3 years, 5 months ago (2017-07-06 21:17:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972113002/1
3 years, 5 months ago (2017-07-06 21:19:11 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 21:24:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6016b060cb2133958b6903a527f...

Powered by Google App Engine
This is Rietveld 408576698