Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/gn/scope.h

Issue 2972113002: Remove ScopedVector from tools/gn/. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/scope.h
diff --git a/tools/gn/scope.h b/tools/gn/scope.h
index 2adcabd20c3d8995a3ce08e330b80c6d69205c55..20a64bc8719ab7609585e241c4bd2b4f62170fb5 100644
--- a/tools/gn/scope.h
+++ b/tools/gn/scope.h
@@ -9,11 +9,11 @@
#include <memory>
#include <set>
#include <utility>
+#include <vector>
#include "base/containers/hash_tables.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_vector.h"
#include "tools/gn/err.h"
#include "tools/gn/input_file.h"
#include "tools/gn/pattern.h"
@@ -41,7 +41,7 @@ class Scope {
typedef base::hash_map<base::StringPiece, Value, base::StringPieceHash>
KeyValueMap;
// Holds an owning list of Items.
- typedef ScopedVector<Item> ItemVector;
+ typedef std::vector<std::unique_ptr<Item>> ItemVector;
// A flag to indicate whether a function should recurse into nested scopes,
// or only operate on the current scope.
« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698