Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: tools/gn/functions.cc

Issue 2972113002: Remove ScopedVector from tools/gn/. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions.cc
diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc
index 41022e67355a977ea84c3ef16c20f5d6b1e45357..09e3647dc7742e3d2f0a269be463c006b58e78fd 100644
--- a/tools/gn/functions.cc
+++ b/tools/gn/functions.cc
@@ -366,7 +366,7 @@ Value RunConfig(const FunctionCallNode* function,
*err = Err(function, "Can't define a config in this context.");
return Value();
}
- collector->push_back(config.release());
+ collector->push_back(std::move(config));
return Value();
}
@@ -919,7 +919,7 @@ Value RunPool(const FunctionCallNode* function,
*err = Err(function, "Can't define a pool in this context.");
return Value();
}
- collector->push_back(pool.release());
+ collector->push_back(std::move(pool));
return Value();
}
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698