Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/function_toolchain.cc

Issue 2972113002: Remove ScopedVector from tools/gn/. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_get_target_outputs_unittest.cc ('k') | tools/gn/functions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index adbab300a9270752354f81cfccda2dd8489cbed2..beef1ea98ec8360b752c1572f2e4da7e6a0abdcc 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -496,7 +496,7 @@ Value RunToolchain(Scope* scope,
*err = Err(function, "Can't define a toolchain in this context.");
return Value();
}
- collector->push_back(toolchain.release());
+ collector->push_back(std::move(toolchain));
return Value();
}
« no previous file with comments | « tools/gn/function_get_target_outputs_unittest.cc ('k') | tools/gn/functions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698