[Opus] Update to v1.2.1

[Opus] Update to v1.2.1

BUG=737323
Review-Url: https://codereview.chromium.org/2962373002
Cr-Commit-Position: refs/heads/master@{#488582}
Committed: https://chromium.googlesource.com/chromium/src/+/0b5dc578114a5237748e6b3da5cbef19a5e75e17

[flim-chromium, 2017-07-05 23:33:04]

The CQ bit was checked by flim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 23:33:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 23:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 23:56:46]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[flim-chromium, 2017-07-07 22:07:02]

Patchset #4 (id:30001) has been deleted

[flim-chromium, 2017-07-07 23:15:45]

Patchset #4 (id:40001) has been deleted

[flim-chromium, 2017-07-07 23:16:28]

Patchset #3 (id:20001) has been deleted

[flim-chromium, 2017-07-08 01:42:49]

The CQ bit was checked by flim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-08 01:43:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-08 03:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-08 03:16:50]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[flim-chromium, 2017-07-10 22:44:24]

Patchset #5 (id:70001) has been deleted

[flim-chromium, 2017-07-12 00:22:09]

The CQ bit was checked by flim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 00:22:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 02:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 02:56:00]

Dry run: This issue passed the CQ dry run.

[flim-chromium, 2017-07-12 18:14:40]

Patchset #5 (id:80001) has been deleted

[flim-chromium, 2017-07-12 23:22:21]

Patchset #5 (id:90001) has been deleted

[flim-chromium, 2017-07-12 23:30:25]

The CQ bit was checked by flim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 23:30:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 03:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 03:06:41]

Dry run: This issue passed the CQ dry run.

[flim-chromium, 2017-07-13 04:44:46]

flim@chromium.org changed reviewers:
+ minyue@chromium.org, miu@chromium.org, rtoy@chromium.org

[flim-chromium, 2017-07-13 04:44:48]

Hi folks, could you please take a look at these changes?
 
+minyue for the opus files

+miu for the media/cast/* changes. These are proposed fixes for the newly
failing tests described in
https://bugs.chromium.org/p/chromium/issues/detail?id=737323

+rtoy for WebKit's regenerated golden

Thanks!

[minyue, 2017-07-13 13:26:37]

lgtm to Opus changes

[Raymond Toy, 2017-07-13 16:30:50]

rtoy@chromium.org changed reviewers:
+ miu@chromium.orgl
- miu@chromium.org

[Raymond Toy, 2017-07-13 16:30:52]

lgtm for opus-decode-expected.wav

Looks like just a few samples differ by a single bit, so I'm ok with this
change.  I assume this difference is not unexpected.

[miu, 2017-07-14 22:01:06]

miu@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2017-07-14 22:01:08]

lgtm

Thanks for posting the graphs and research details in the crbug. It's
interesting to see that Opus 1.2 seems to take a longer time to "ramp up" the
signal power after a reset. Perhaps they decided to do that to reduce jarring
"click" effects when first starting audio playback?

https://codereview.chromium.org/2962373002/diff/100001/media/cast/receiver/au...
File media/cast/receiver/audio_decoder_unittest.cc (right):

https://codereview.chromium.org/2962373002/diff/100001/media/cast/receiver/au...
media/cast/receiver/audio_decoder_unittest.cc:166: decoded_frames_seen_++;
style nit: Please use pre-increment instead of post-increment, to be consistent
with the rest of the code.

[flim-chromium, 2017-07-14 22:36:51]

miu@: Not too sure - the first few samples from the decoder are not useful
anyway, since there are initialization latencies and the encoder adds some
padding to compensate.

rtoy@: Right, there were a bunch of changes to improve quality so it's not
surprising to see non-bit-exactness.

Thanks everyone for the reviews!

https://codereview.chromium.org/2962373002/diff/100001/media/cast/receiver/au...
File media/cast/receiver/audio_decoder_unittest.cc (right):

https://codereview.chromium.org/2962373002/diff/100001/media/cast/receiver/au...
media/cast/receiver/audio_decoder_unittest.cc:166: decoded_frames_seen_++;
On 2017/07/14 22:01:08, miu wrote:
> style nit: Please use pre-increment instead of post-increment, to be
consistent
> with the rest of the code.

Done.

[flim-chromium, 2017-07-14 22:40:29]

The CQ bit was checked by flim@chromium.org

[flim-chromium, 2017-07-14 22:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@chromium.org,
rtoy@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2962373002/#ps110001
(title: "Pre-increment instead of post-increment")

[commit-bot: I haz the power, 2017-07-14 22:40:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 22:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 22:55:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[flim-chromium, 2017-07-14 23:07:57]

flim@chromium.org changed reviewers:
+ brettw@chromium.org, henrika@chromium.org

[flim-chromium, 2017-07-14 23:07:59]

+henrika and brettw for OWNERS approval

Thanks!

[henrika (OOO until Aug 14), 2017-07-17 07:49:48]

lgtm

[brettw, 2017-07-17 19:27:03]

There is an OWNERS file for third_party/opus, why is my review needed here?

[flim-chromium, 2017-07-17 20:52:20]

On 2017/07/17 19:27:03, brettw wrote:
> There is an OWNERS file for third_party/opus, why is my review needed here?

Apologies, an earlier local presubmit seemed to indicate that approval from
ENG_REVIEW_OWNERS was needed for third_party/opus/DEPS. Will remove you from the
reviewer list. 

Thanks!

[flim-chromium, 2017-07-17 20:52:59]

flim@chromium.org changed reviewers:
- brettw@chromium.org, miu@chromium.orgl

[flim-chromium, 2017-07-17 20:53:06]

-brettw

[flim-chromium, 2017-07-17 20:53:15]

The CQ bit was checked by flim@chromium.org

[commit-bot: I haz the power, 2017-07-17 20:53:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-17 21:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-17 21:11:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[flim-chromium, 2017-07-17 21:42:27]

flim@chromium.org changed reviewers:
+ brettw@chromium.org

[flim-chromium, 2017-07-17 21:42:29]

Sorry brettw, looks like your approval is still needed for
third_party/opus/DEPS. Could you please take a look?

Thanks!

[brettw, 2017-07-19 21:42:00]

lgtm

[flim-chromium, 2017-07-19 21:42:46]

The CQ bit was checked by flim@chromium.org

[commit-bot: I haz the power, 2017-07-19 21:43:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 22:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-19 22:48:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[flim-chromium, 2017-07-21 01:37:32]

The CQ bit was checked by flim@chromium.org

[commit-bot: I haz the power, 2017-07-21 01:37:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-21 04:35:47]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1500601052700210,
"parent_rev": "40e9e5f0a1a32bea870e6f0271c97c44f12666b8", "commit_rev":
"0b5dc578114a5237748e6b3da5cbef19a5e75e17"}

[commit-bot: I haz the power, 2017-07-21 04:36:04]

Description was changed from

==========
[Opus] Update to v1.2.1

BUG=737323
==========

to

==========
[Opus] Update to v1.2.1

BUG=737323

Review-Url: https://codereview.chromium.org/2962373002
Cr-Commit-Position: refs/heads/master@{#488582}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b5dc578114a5237748e6b3da5cb...
==========

[commit-bot: I haz the power, 2017-07-21 04:36:06]

Committed patchset #6 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/0b5dc578114a5237748e6b3da5cb...