Updates to Server-Timing in accordance with with spec changes

Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array as `serverTiming` on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=702760
Review-Url: https://codereview.chromium.org/2962113002
Cr-Commit-Position: refs/heads/master@{#484536}
Committed: https://chromium.googlesource.com/chromium/src/+/03ba6110113f1439b239b6142c130e60fc9b4519

[cvazac-akam, 2017-06-29 02:43:30]

Description was changed from

==========
Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=
==========

to

==========
Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array as `serverTiming` on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=
==========

[Yoav Weiss, 2017-06-29 06:57:32]

yoav@yoav.ws changed reviewers:
+ yoav@yoav.ws

[Yoav Weiss, 2017-06-29 06:57:34]

Thanks for working on this! :) A few comments below

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/Performance.cpp:149:
PerformanceServerTimingVector serverTiming = ParseServerTiming(*info, true);
It's hard to know what "true" here means from the caller site, which is why we
usually prefer enums for such flags. Can you replace the boolean with an enum?

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/Performance.h (right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/Performance.h:46:
HeapVector<Member<PerformanceServerTiming>>;
Remove the definition from here and define it in a single place in
PerformanceServerTiming.h

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:294:
PerformanceServerTimingVector PerformanceBase::ParseServerTiming(
I think it'd make more sense to move this function to be static on
PerformanceServerTiming

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceBase.h (right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceBase.h:63:
HeapVector<Member<PerformanceServerTiming>>;
Remove the definition from here.

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
(right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h:26:
HeapVector<Member<PerformanceServerTiming>>;
Remove the definition from here

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp
(right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp:72:
serverTiming_.AppendVector(serverTiming);
Why AppendVector? serverTiming_ is empty here. I think it'd be clearer if you
simply initialize using `serverTiming_(serverTiming)`

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h (right):

https://codereview.chromium.org/2962113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h:47:
HeapVector<Member<PerformanceServerTiming>>;
Remove the definition from here

[Yoav Weiss, 2017-06-29 16:23:21]

LGTM % nits

https://codereview.chromium.org/2962113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.h (right):

https://codereview.chromium.org/2962113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.h:42: #include
"core/timing/PerformanceServerTiming.h"
I think you no longer need that include

https://codereview.chromium.org/2962113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp
(right):

https://codereview.chromium.org/2962113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp:82:
serverTiming_.AppendVector(serverTiming);
Same comment regarding `AppendVector` here

https://codereview.chromium.org/2962113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp (right):

https://codereview.chromium.org/2962113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp:53: : false));
Might be better to avoid translating the enum back to a boolean here, and just
use the enum directly

[Yoav Weiss, 2017-06-29 21:06:02]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 21:06:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 21:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:09:24]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2017-06-30 21:39:12]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 21:39:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-06-30 21:57:25]

Description was changed from

==========
Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array as `serverTiming` on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=
==========

to

==========
Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array as `serverTiming` on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=702760
==========

[Yoav Weiss, 2017-06-30 21:58:43]

yoav@yoav.ws changed reviewers:
+ mkwst@chromium.org

[Yoav Weiss, 2017-06-30 21:58:43]

Hey Mike! Care to take a look at the platform/ parts?

[commit-bot: I haz the power, 2017-06-30 23:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 23:36:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2017-07-01 05:05:05]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 05:05:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 05:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 05:59:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2017-07-01 06:29:41]

Charlie - A bunch of failing tests seem relevant

[Mike West, 2017-07-03 08:22:50]

platform bits LGTM. Deferring the rest to Yoav. :)

[Yoav Weiss, 2017-07-06 08:52:30]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 08:52:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 10:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 10:44:35]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2017-07-06 10:44:57]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2017-07-06 10:44:57]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2962113002/#ps100001
(title: "fix web-platform-tests")

[commit-bot: I haz the power, 2017-07-06 10:45:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 10:49:01]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499337897397980,
"parent_rev": "967b256250d1e7777ca458aa062ded48628c370d", "commit_rev":
"03ba6110113f1439b239b6142c130e60fc9b4519"}

[commit-bot: I haz the power, 2017-07-06 10:49:13]

Description was changed from

==========
Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array as `serverTiming` on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=702760
==========

to

==========
Per the new server-timing spec
(https://github.com/w3c/server-timing), there are no longer standalone
`server` entries emitted to PerformanceObservers or found in the
timeline. Server-timing data now comes down in an Array as `serverTiming` on the
corresponding PerformanceResourceTiming entry for subresources, and on
the PerformanceNavigationTiming entry for the basepage. Also,
PerformanceServerTiming no longer extends PerformanceEntry, because
half of the fields either held no value (startTime) or were redundant
(name, entryType). Lastly, we are going to name the numeric "value"
instead of "duration", because it's just a double.

BUG=702760

Review-Url: https://codereview.chromium.org/2962113002
Cr-Commit-Position: refs/heads/master@{#484536}
Committed:
https://chromium.googlesource.com/chromium/src/+/03ba6110113f1439b239b6142c13...
==========

[commit-bot: I haz the power, 2017-07-06 10:49:15]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/03ba6110113f1439b239b6142c13...