Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceServerTiming.h

Issue 2962113002: Updates to Server-Timing in accordance with with spec changes (Closed)
Patch Set: fix web-platform-tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceServerTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceServerTiming.h b/third_party/WebKit/Source/core/timing/PerformanceServerTiming.h
index 814dfe415d32e1281ead143440b8e15a6da5cfec..815bb363b39921b7a54c77795ecb61985dc9e60b 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceServerTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceServerTiming.h
@@ -5,37 +5,52 @@
#ifndef PerformanceServerTiming_h
#define PerformanceServerTiming_h
-#include "core/timing/PerformanceEntry.h"
+#include "bindings/core/v8/V8ObjectBuilder.h"
+#include "platform/bindings/ScriptWrappable.h"
+#include "platform/wtf/text/WTFString.h"
namespace blink {
-class CORE_EXPORT PerformanceServerTiming : public PerformanceEntry {
+class ResourceTimingInfo;
+class PerformanceServerTiming;
+
+using PerformanceServerTimingVector =
+ HeapVector<Member<PerformanceServerTiming>>;
+
+class CORE_EXPORT PerformanceServerTiming final
+ : public GarbageCollectedFinalized<PerformanceServerTiming>,
+ public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- ~PerformanceServerTiming() override;
+ enum class ShouldAllowTimingDetails {
+ Yes,
+ No,
+ };
- static PerformanceServerTiming* create(const String& name,
- const String& metric,
- double duration,
- const String& description) {
- return new PerformanceServerTiming(name, metric, duration, description);
- }
+ PerformanceServerTiming(const String& metric,
+ double value,
+ const String& description,
+ ShouldAllowTimingDetails);
+ ~PerformanceServerTiming();
String metric() const;
+ double value() const;
String description() const;
- protected:
- void BuildJSONValue(V8ObjectBuilder&) const override;
+ static PerformanceServerTimingVector ParseServerTiming(
+ const ResourceTimingInfo&,
+ ShouldAllowTimingDetails);
- private:
- PerformanceServerTiming(const String& name,
- const String& metric,
- double duration,
- const String& description);
+ ScriptValue toJSONForBinding(ScriptState*) const;
+ DEFINE_INLINE_VIRTUAL_TRACE() {}
+
+ private:
const String metric_;
+ double value_;
const String description_;
+ ShouldAllowTimingDetails shouldAllowTimingDetails_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698