Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp

Issue 2962113002: Updates to Server-Timing in accordance with with spec changes (Closed)
Patch Set: address CR comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 27 matching lines...) Expand all
38 #include "platform/loader/fetch/ResourceTimingInfo.h" 38 #include "platform/loader/fetch/ResourceTimingInfo.h"
39 39
40 namespace blink { 40 namespace blink {
41 41
42 PerformanceResourceTiming::PerformanceResourceTiming( 42 PerformanceResourceTiming::PerformanceResourceTiming(
43 const ResourceTimingInfo& info, 43 const ResourceTimingInfo& info,
44 double time_origin, 44 double time_origin,
45 double start_time, 45 double start_time,
46 double last_redirect_end_time, 46 double last_redirect_end_time,
47 bool allow_timing_details, 47 bool allow_timing_details,
48 bool allow_redirect_details) 48 bool allow_redirect_details,
49 PerformanceServerTimingVector& serverTiming)
49 : PerformanceEntry(info.InitialURL().GetString(), 50 : PerformanceEntry(info.InitialURL().GetString(),
50 "resource", 51 "resource",
51 PerformanceBase::MonotonicTimeToDOMHighResTimeStamp( 52 PerformanceBase::MonotonicTimeToDOMHighResTimeStamp(
52 time_origin, 53 time_origin,
53 start_time, 54 start_time,
54 info.NegativeAllowed()), 55 info.NegativeAllowed()),
55 PerformanceBase::MonotonicTimeToDOMHighResTimeStamp( 56 PerformanceBase::MonotonicTimeToDOMHighResTimeStamp(
56 time_origin, 57 time_origin,
57 info.LoadFinishTime(), 58 info.LoadFinishTime(),
58 info.NegativeAllowed())), 59 info.NegativeAllowed())),
59 initiator_type_(info.InitiatorType()), 60 initiator_type_(info.InitiatorType()),
60 time_origin_(time_origin), 61 time_origin_(time_origin),
61 timing_(info.FinalResponse().GetResourceLoadTiming()), 62 timing_(info.FinalResponse().GetResourceLoadTiming()),
62 last_redirect_end_time_(last_redirect_end_time), 63 last_redirect_end_time_(last_redirect_end_time),
63 finish_time_(info.LoadFinishTime()), 64 finish_time_(info.LoadFinishTime()),
64 transfer_size_(info.TransferSize()), 65 transfer_size_(info.TransferSize()),
65 encoded_body_size_(info.FinalResponse().EncodedBodyLength()), 66 encoded_body_size_(info.FinalResponse().EncodedBodyLength()),
66 decoded_body_size_(info.FinalResponse().DecodedBodyLength()), 67 decoded_body_size_(info.FinalResponse().DecodedBodyLength()),
67 did_reuse_connection_(info.FinalResponse().ConnectionReused()), 68 did_reuse_connection_(info.FinalResponse().ConnectionReused()),
68 allow_timing_details_(allow_timing_details), 69 allow_timing_details_(allow_timing_details),
69 allow_redirect_details_(allow_redirect_details), 70 allow_redirect_details_(allow_redirect_details),
70 allow_negative_value_(info.NegativeAllowed()) {} 71 allow_negative_value_(info.NegativeAllowed()),
72 serverTiming_(serverTiming) {}
71 73
72 // This constructor is for PerformanceNavigationTiming. 74 // This constructor is for PerformanceNavigationTiming.
73 PerformanceResourceTiming::PerformanceResourceTiming(const String& name, 75 PerformanceResourceTiming::PerformanceResourceTiming(
74 const String& entry_type, 76 const String& name,
75 double start_time, 77 const String& entry_type,
76 double duration) 78 double start_time,
77 : PerformanceEntry(name, entry_type, start_time, duration) {} 79 double duration,
80 PerformanceServerTimingVector& serverTiming)
81 : PerformanceEntry(name, entry_type, start_time, duration) {
82 serverTiming_.AppendVector(serverTiming);
Yoav Weiss 2017/06/29 16:23:21 Same comment regarding `AppendVector` here
83 }
78 84
79 PerformanceResourceTiming::~PerformanceResourceTiming() {} 85 PerformanceResourceTiming::~PerformanceResourceTiming() {}
80 86
81 ResourceLoadTiming* PerformanceResourceTiming::GetResourceLoadTiming() const { 87 ResourceLoadTiming* PerformanceResourceTiming::GetResourceLoadTiming() const {
82 return timing_.Get(); 88 return timing_.Get();
83 } 89 }
84 90
85 bool PerformanceResourceTiming::AllowTimingDetails() const { 91 bool PerformanceResourceTiming::AllowTimingDetails() const {
86 return allow_timing_details_; 92 return allow_timing_details_;
87 } 93 }
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 return GetEncodedBodySize(); 273 return GetEncodedBodySize();
268 } 274 }
269 275
270 unsigned long long PerformanceResourceTiming::decodedBodySize() const { 276 unsigned long long PerformanceResourceTiming::decodedBodySize() const {
271 if (!AllowTimingDetails()) 277 if (!AllowTimingDetails())
272 return 0; 278 return 0;
273 279
274 return GetDecodedBodySize(); 280 return GetDecodedBodySize();
275 } 281 }
276 282
283 PerformanceServerTimingVector PerformanceResourceTiming::serverTiming() const {
284 return serverTiming_;
285 }
286
277 void PerformanceResourceTiming::BuildJSONValue(V8ObjectBuilder& builder) const { 287 void PerformanceResourceTiming::BuildJSONValue(V8ObjectBuilder& builder) const {
278 PerformanceEntry::BuildJSONValue(builder); 288 PerformanceEntry::BuildJSONValue(builder);
279 builder.AddString("initiatorType", initiatorType()); 289 builder.AddString("initiatorType", initiatorType());
280 builder.AddNumber("workerStart", workerStart()); 290 builder.AddNumber("workerStart", workerStart());
281 builder.AddNumber("redirectStart", redirectStart()); 291 builder.AddNumber("redirectStart", redirectStart());
282 builder.AddNumber("redirectEnd", redirectEnd()); 292 builder.AddNumber("redirectEnd", redirectEnd());
283 builder.AddNumber("fetchStart", fetchStart()); 293 builder.AddNumber("fetchStart", fetchStart());
284 builder.AddNumber("domainLookupStart", domainLookupStart()); 294 builder.AddNumber("domainLookupStart", domainLookupStart());
285 builder.AddNumber("domainLookupEnd", domainLookupEnd()); 295 builder.AddNumber("domainLookupEnd", domainLookupEnd());
286 builder.AddNumber("connectStart", connectStart()); 296 builder.AddNumber("connectStart", connectStart());
287 builder.AddNumber("connectEnd", connectEnd()); 297 builder.AddNumber("connectEnd", connectEnd());
288 builder.AddNumber("secureConnectionStart", secureConnectionStart()); 298 builder.AddNumber("secureConnectionStart", secureConnectionStart());
289 builder.AddNumber("requestStart", requestStart()); 299 builder.AddNumber("requestStart", requestStart());
290 builder.AddNumber("responseStart", responseStart()); 300 builder.AddNumber("responseStart", responseStart());
291 builder.AddNumber("responseEnd", responseEnd()); 301 builder.AddNumber("responseEnd", responseEnd());
292 builder.AddNumber("transferSize", transferSize()); 302 builder.AddNumber("transferSize", transferSize());
293 builder.AddNumber("encodedBodySize", encodedBodySize()); 303 builder.AddNumber("encodedBodySize", encodedBodySize());
294 builder.AddNumber("decodedBodySize", decodedBodySize()); 304 builder.AddNumber("decodedBodySize", decodedBodySize());
295 } 305 }
296 306
307 DEFINE_TRACE(PerformanceResourceTiming) {
308 visitor->Trace(serverTiming_);
309 PerformanceEntry::Trace(visitor);
310 }
311
297 } // namespace blink 312 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698