Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

Issue 2962113002: Updates to Server-Timing in accordance with with spec changes (Closed)
Patch Set: fix web-platform-tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceEntry.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp b/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp
index 9afabfbc8518eb4fa00ea17937058f79fbd34aee..9e74757fbaa9c53d828ccb9f2eaa5068064890c9 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp
@@ -83,19 +83,18 @@ PerformanceEntry::EntryType PerformanceEntry::ToEntryTypeEnum(
return kTaskAttribution;
if (entry_type == "paint")
return kPaint;
- if (entry_type == "server")
- return kServer;
return kInvalid;
}
ScriptValue PerformanceEntry::toJSONForBinding(
ScriptState* script_state) const {
V8ObjectBuilder result(script_state);
- BuildJSONValue(result);
+ BuildJSONValue(script_state, result);
return result.GetScriptValue();
}
-void PerformanceEntry::BuildJSONValue(V8ObjectBuilder& builder) const {
+void PerformanceEntry::BuildJSONValue(ScriptState* script_state,
+ V8ObjectBuilder& builder) const {
builder.AddString("name", name());
builder.AddString("entryType", entryType());
builder.AddNumber("startTime", startTime());

Powered by Google App Engine
This is Rietveld 408576698