Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2962063002: DevTools: eliminate {Default,Resource}ScriptMapping.addScript method (Closed)

Created:
3 years, 5 months ago by lushnikov
Modified:
3 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: eliminate {Default,Resource}ScriptMapping.addScript method This patch eliminates addScript/removeScript event routing through DebuggerWorkspaceBinding. This patch is a pre-step before moving UISourceCode management into ResourceScriptMapping. R=dgozman BUG=670180 Review-Url: https://codereview.chromium.org/2962063002 Cr-Commit-Position: refs/heads/master@{#483258} Committed: https://chromium.googlesource.com/chromium/src/+/dbf773464704499610b86e6df03a97303521548a

Patch Set 1 #

Patch Set 2 : remove code from breakpoint-manager.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -54 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 1 3 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js View 5 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 2 chunks +6 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
lushnikov
please, take a look
3 years, 5 months ago (2017-06-28 22:51:13 UTC) #1
dgozman
lgtm
3 years, 5 months ago (2017-06-28 23:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962063002/20001
3 years, 5 months ago (2017-06-29 02:03:54 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 02:08:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbf773464704499610b86e6df03a...

Powered by Google App Engine
This is Rietveld 408576698