Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js

Issue 2962063002: DevTools: eliminate {Default,Resource}ScriptMapping.addScript method (Closed)
Patch Set: remove code from breakpoint-manager.js Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
index 9fbb5dc7d19e3a9808e1a803d6c7530a12f20b7d..a3a32c3b77676ac41cb48ba918607f12a0ccbdb4 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
@@ -40,11 +40,17 @@ Bindings.DefaultScriptMapping = class {
constructor(debuggerModel, workspace, debuggerWorkspaceBinding) {
this._debuggerModel = debuggerModel;
this._debuggerWorkspaceBinding = debuggerWorkspaceBinding;
- var projectId = Bindings.DefaultScriptMapping.projectIdForTarget(debuggerModel.target());
this._project = new Bindings.ContentProviderBasedProject(
- workspace, projectId, Workspace.projectTypes.Debugger, '', true /* isServiceProject */);
- this._eventListeners =
- [debuggerModel.addEventListener(SDK.DebuggerModel.Events.GlobalObjectCleared, this._debuggerReset, this)];
+ workspace, 'debugger:' + debuggerModel.target().id(), Workspace.projectTypes.Debugger, '',
+ true /* isServiceProject */);
+ this._eventListeners = [
+ debuggerModel.addEventListener(SDK.DebuggerModel.Events.GlobalObjectCleared, this._debuggerReset, this),
+ debuggerModel.addEventListener(SDK.DebuggerModel.Events.ParsedScriptSource, this._parsedScriptSource, this),
+ debuggerModel.addEventListener(
+ SDK.DebuggerModel.Events.FailedToParseScriptSource, this._parsedScriptSource, this),
+ debuggerModel.addEventListener(
+ SDK.DebuggerModel.Events.DiscardedAnonymousScriptSource, this._discardedScriptSource, this)
+ ];
}
/**
@@ -55,14 +61,6 @@ Bindings.DefaultScriptMapping = class {
return uiSourceCode[Bindings.DefaultScriptMapping._scriptSymbol] || null;
}
- /**
- * @param {!SDK.Target} target
- * @return {string}
- */
- static projectIdForTarget(target) {
- return 'debugger:' + target.id();
- }
-
/**
* @override
* @param {!SDK.DebuggerModel.Location} rawLocation
@@ -99,9 +97,10 @@ Bindings.DefaultScriptMapping = class {
}
/**
- * @param {!SDK.Script} script
+ * @param {!Common.Event} event
*/
- addScript(script) {
+ _parsedScriptSource(event) {
+ var script = /** @type {!SDK.Script} */ (event.data);
var name = Common.ParsedURL.extractName(script.sourceURL);
var url = 'debugger:///VM' + script.scriptId + (name ? ' ' + name : '');
@@ -113,9 +112,10 @@ Bindings.DefaultScriptMapping = class {
}
/**
- * @param {!SDK.Script} script
+ * @param {!Common.Event} event
*/
- removeScript(script) {
+ _discardedScriptSource(event) {
+ var script = /** @type {!SDK.Script} */ (event.data);
var uiSourceCode = script[Bindings.DefaultScriptMapping._uiSourceCodeSymbol];
if (!uiSourceCode)
return;
@@ -136,4 +136,4 @@ Bindings.DefaultScriptMapping = class {
};
Bindings.DefaultScriptMapping._scriptSymbol = Symbol('symbol');
-Bindings.DefaultScriptMapping._uiSourceCodeSymbol = Symbol('uiSourceCodeSymbol');
+Bindings.DefaultScriptMapping._uiSourceCodeSymbol = Symbol('uiSourceCodeSymbol');

Powered by Google App Engine
This is Rietveld 408576698