Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2958403002: [WIP] DevTools: move UISourceCode creation into ResourceScriptMapping

Created:
3 years, 5 months ago by lushnikov
Modified:
3 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] DevTools: move UISourceCode creation into ResourceScriptMapping Move scripts uiSourceCode management over to ResourceScriptMapping. This changes the order of UISourceCode creation - which results in a bad breakage of breakpoint-manager.html test. Still failing: inspector/sources/debugger-breakpoints/breakpoint-manager.html [ Failure ]

Patch Set 1 #

Patch Set 2 : pass everything but breakpointmanager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -385 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/extensions/extensions-resources.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-with-same-source-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html View 1 1 chunk +20 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 3 chunks +0 lines, -225 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 1 16 chunks +134 lines, -118 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
lushnikov
This is a WIP patch - not intended to be landed. This patch destroys the ...
3 years, 5 months ago (2017-06-30 00:56:22 UTC) #3
dgozman
3 years, 5 months ago (2017-07-15 05:58:05 UTC) #4 
Let's finish this!

Powered by Google App Engine
This is Rietveld 408576698