Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

Issue 2962063002: DevTools: eliminate {Default,Resource}ScriptMapping.addScript method (Closed)
Patch Set: remove code from breakpoint-manager.js Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
index b0e68d4d06f2db7a7225aad816135317ad1bfa22..402c991d34366566ee43889c0e6387d826d9e986 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
@@ -42,7 +42,7 @@ InspectorTest.initializeDefaultMappingOnTarget = function(target)
var defaultMapping = {
rawLocationToUILocation: function(rawLocation)
{
- return InspectorTest.uiSourceCodes[rawLocation.scriptId].uiLocation(rawLocation.lineNumber, 0);
+ return null;
},
uiLocationToRawLocation: function(uiSourceCode, lineNumber)
@@ -103,7 +103,9 @@ InspectorTest.DebuggerModelMock = class extends SDK.SDKModel {
{
var script = new SDK.Script(this, scriptId, url);
this._scripts[scriptId] = script;
- this._debuggerWorkspaceBinding._debuggerModelToData.get(this)._parsedScriptSource({data: script});
+ var modelData = this._debuggerWorkspaceBinding._debuggerModelToData.get(this);
+ modelData._defaultMapping._parsedScriptSource({data: script});
+ modelData._resourceMapping._parsedScriptSource({data: script});
}
_scriptForURL(url)
@@ -227,14 +229,6 @@ InspectorTest.addScript = function(target, breakpointManager, url)
{
target.debuggerModel._addScript(url, url);
InspectorTest.addResult(" Adding script: " + url);
- var uiSourceCodes = breakpointManager._workspace.uiSourceCodesForProjectType(Workspace.projectTypes.Debugger);
- for (var i = 0; i < uiSourceCodes.length; ++i) {
- var uiSourceCode = uiSourceCodes[i];
- if (uiSourceCode.url() === url) {
- InspectorTest.uiSourceCodes[url] = uiSourceCode;
- return uiSourceCode;
- }
- }
}
InspectorTest.addUISourceCode = function(target, breakpointManager, url, doNotSetSourceMapping, doNotAddScript)
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698