Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2961943002: Remove LTO-related hacks from binutils build script. (Closed)

Created:
3 years, 5 months ago by pcc1
Modified:
3 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LTO-related hacks from binutils build script. This effectively reverts: https://codereview.chromium.org/1330433002 (link against LLVM's libstdc++) https://codereview.chromium.org/1670073003 (link against tcmalloc) and part of https://codereview.chromium.org/899783003 (export plugin-api.h) All of which were to support use of LLVM's gold plugin for LTO. Because we no longer build or use the gold plugin, we no longer need this complexity in the build script. BUG=607968 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2961943002 Cr-Commit-Position: refs/heads/master@{#483173} Committed: https://chromium.googlesource.com/chromium/src/+/effae3bbe9479ad36042df4b4a5db3dc3ebf0c41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -69 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/binutils/build-all.sh View 4 chunks +1 line, -11 lines 0 comments Download
M third_party/binutils/build-one.sh View 2 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pcc1
3 years, 5 months ago (2017-06-28 03:37:54 UTC) #1
pcc1
(depends on https://codereview.chromium.org/2963693002/)
3 years, 5 months ago (2017-06-28 03:39:51 UTC) #2
Nico
lgtm!
3 years, 5 months ago (2017-06-28 15:34:26 UTC) #3
Nico
cc thestig fyi
3 years, 5 months ago (2017-06-28 15:35:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961943002/1
3 years, 5 months ago (2017-06-28 22:22:04 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 22:26:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/effae3bbe9479ad36042df4b4a5d...

Powered by Google App Engine
This is Rietveld 408576698