Link binutils with tcmalloc_minimal.

Link binutils with tcmalloc_minimal. This speeds up linking large targets with LTO by 10%.

BUG=583551
R=thestig@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/52a773ded943a19c880b2d2dd673d56d35aa3f03

[krasin1, 2016-02-05 07:51:08]

krasin@chromium.org changed reviewers:
+ krasin@chromium.org, pcc@chromium.com, thakis@chromium.org

[krasin1, 2016-02-05 07:51:25]

Description was changed from

==========
Add a note to README.chromium


Link binutils with tcmalloc_minimal. This speeds up linking large targets with
LTO by 10%.

BUG=583551
==========

to

==========
Link binutils with tcmalloc_minimal. This speeds up linking large targets with
LTO by 10%.

BUG=583551
==========

[krasin1, 2016-02-05 07:55:19]

krasin@chromium.org changed reviewers:
- krasin@chromium.org

[krasin1, 2016-02-05 08:03:39]

krasin@chromium.org changed reviewers:
+ krasin@chromium.org

[krasin1, 2016-02-05 08:03:39]

Note: this builds against tcmalloc 2.4 (released in Jan 2015), instead of using
a version of tcmalloc from Precise. I considered the latter, but after reviewing
the list of changes to tcmalloc since that time, I decided it's worth getting
the latest stable version.

[krasin1, 2016-02-05 08:15:18]

I realize that this CL also misses binutils.tar.bz2.sha1 updates for Linux_x64
and Linux_ia32. I will upload the binaries and update the CL tomorrow.

[krasin1, 2016-02-05 21:03:38]

krasin@chromium.org changed reviewers:
+ pcc@chromium.org
- krasin@chromium.org, pcc@chromium.com

[krasin1, 2016-02-05 21:03:56]

1) I could not upload the binaries, because I don't have an access to
gs://chromium-binutils
2) I have measured the impact of this change to the regular, non-LTO case. None.
https://docs.google.com/a/google.com/spreadsheets/d/1WcXsmm8mMh0ZHAq4Fr0sos4a...

Nico, Peter,
please, take a look at the CL.

[Nico, 2016-02-05 21:04:33]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org

[Nico, 2016-02-05 21:04:34]

Lei or Peter should review this.

Nice!

[Lei Zhang, 2016-02-05 21:21:00]

looks ok, just some nits.

I've never uploaded anything, so I don't know about permissions for
gs://chromium-binutils

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
File third_party/binutils/build-all.sh (right):

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
third_party/binutils/build-all.sh:77:
--include=build-essential,flex,bison,autoconf,libtool,automake \
Can you make a couple variables for binutils build requirements, and gperftools
build requirements, and use them here? Rearranging the packages in the variables
to be alphabetical order too.

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
File third_party/binutils/build-one.sh (right):

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
third_party/binutils/build-one.sh:35: export
LDFLAGS="-Wl,-rpath,zORIGIN/../../../../llvm-build/Release+Asserts/lib:zORIGIN/../lib
-L$(pwd)/../gperftools/.libs/"
Can you update the comment above to mention the additional RPATH?

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
third_party/binutils/build-one.sh:35: export
LDFLAGS="-Wl,-rpath,zORIGIN/../../../../llvm-build/Release+Asserts/lib:zORIGIN/../lib
-L$(pwd)/../gperftools/.libs/"
It would be nice to keep this at 80 chars / line. Hopefully that won't be too
ugly?

[krasin1, 2016-02-05 21:50:30]

Patchset #3 (id:40001) has been deleted

[krasin1, 2016-02-05 21:50:39]

Patchset #2 (id:20001) has been deleted

[krasin1, 2016-02-05 21:51:53]

krasin@chromium.org changed reviewers:
+ krasin@chromium.org

[krasin1, 2016-02-05 21:51:53]

Done. Please, take another look.

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
File third_party/binutils/build-all.sh (right):

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
third_party/binutils/build-all.sh:77:
--include=build-essential,flex,bison,autoconf,libtool,automake \
On 2016/02/05 21:21:00, Lei Zhang wrote:
> Can you make a couple variables for binutils build requirements, and
gperftools
> build requirements, and use them here? Rearranging the packages in the
variables
> to be alphabetical order too.

Done.

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
File third_party/binutils/build-one.sh (right):

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
third_party/binutils/build-one.sh:35: export
LDFLAGS="-Wl,-rpath,zORIGIN/../../../../llvm-build/Release+Asserts/lib:zORIGIN/../lib
-L$(pwd)/../gperftools/.libs/"
On 2016/02/05 21:21:00, Lei Zhang wrote:
> It would be nice to keep this at 80 chars / line. Hopefully that won't be too
> ugly?

Done.

https://codereview.chromium.org/1670073003/diff/1/third_party/binutils/build-...
third_party/binutils/build-one.sh:35: export
LDFLAGS="-Wl,-rpath,zORIGIN/../../../../llvm-build/Release+Asserts/lib:zORIGIN/../lib
-L$(pwd)/../gperftools/.libs/"
On 2016/02/05 21:21:00, Lei Zhang wrote:
> Can you update the comment above to mention the additional RPATH?

Done.

[Lei Zhang, 2016-02-05 22:21:32]

lgtm

[krasin1, 2016-02-05 22:30:26]

On 2016/02/05 22:21:32, Lei Zhang wrote:
> lgtm

Thank you. I will land the CL once I get a confirmation from goma team.

[krasin1, 2016-02-09 01:35:27]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-02-09 01:50:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670073003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670073003/60001

[commit-bot: I haz the power, 2016-02-09 02:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 02:55:55]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[commit-bot: I haz the power, 2016-02-09 02:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 03:00:48]

Description was changed from

==========
Link binutils with tcmalloc_minimal. This speeds up linking large targets with
LTO by 10%.

BUG=583551
==========

to

==========
Link binutils with tcmalloc_minimal. This speeds up linking large targets with
LTO by 10%.

BUG=583551
R=thestig@chromium.org

Committed: https://crrev.com/52a773ded943a19c880b2d2dd673d56d35aa3f03
Cr-Commit-Position: refs/heads/master@{#374283}
==========

[commit-bot: I haz the power, 2016-02-09 03:00:49]

Patchset 2 (id:??) landed as
https://crrev.com/52a773ded943a19c880b2d2dd673d56d35aa3f03
Cr-Commit-Position: refs/heads/master@{#374283}

[krasin, 2016-02-09 03:01:15]

Description was changed from

==========
Link binutils with tcmalloc_minimal. This speeds up linking large targets with
LTO by 10%.

BUG=583551
R=thestig@chromium.org

Committed: https://crrev.com/52a773ded943a19c880b2d2dd673d56d35aa3f03
Cr-Commit-Position: refs/heads/master@{#374283}
==========

to

==========
Link binutils with tcmalloc_minimal. This speeds up linking large targets with
LTO by 10%.

BUG=583551
R=thestig@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/52a773ded943a19c880b2d2dd673...
==========

[krasin, 2016-02-09 03:01:17]

Committed patchset #2 (id:60001) manually as
52a773ded943a19c880b2d2dd673d56d35aa3f03 (presubmit successful).