Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1330433002: binutils: Embed a relative path to the LLVM lib directory in binaries' rpaths. (Closed)

Created:
5 years, 3 months ago by pcc1
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, Nico, pcc, krasin
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binutils: Embed a relative path to the LLVM lib directory in binaries' rpaths. This ensures that the correct version of libstdc++ is loaded by gold before it loads the LLVM LTO plugin. See bug for details. BUG=521143 R=thestig@chromium.org,thakis@chromium.org,krasin@google.com Committed: https://crrev.com/2b4b72b16d655c497dcc4693d3577bf01b71e992 Cr-Commit-Position: refs/heads/master@{#348478}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments #

Patch Set 3 : Drop DEPS change #

Patch Set 4 : Update binaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/build-one.sh View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (3 generated)
pcc1
5 years, 3 months ago (2015-09-02 02:56:27 UTC) #1
krasin
https://codereview.chromium.org/1330433002/diff/1/third_party/binutils/build-one.sh File third_party/binutils/build-one.sh (right): https://codereview.chromium.org/1330433002/diff/1/third_party/binutils/build-one.sh#newcode32 third_party/binutils/build-one.sh:32: bins="`echo /build/output/*/bin/*`" I believe that generally "$(echo /build/output/*/bin/*)" is ...
5 years, 3 months ago (2015-09-02 03:09:54 UTC) #2
krasin
Thank you, Peter! I had an ugly but working fix for the same issue, which ...
5 years, 3 months ago (2015-09-02 03:10:51 UTC) #3
krasin
5 years, 3 months ago (2015-09-02 03:11:02 UTC) #4
Lei Zhang
I defer to Nico.
5 years, 3 months ago (2015-09-03 22:18:19 UTC) #5
pcc
https://codereview.chromium.org/1330433002/diff/1/third_party/binutils/build-one.sh File third_party/binutils/build-one.sh (right): https://codereview.chromium.org/1330433002/diff/1/third_party/binutils/build-one.sh#newcode32 third_party/binutils/build-one.sh:32: bins="`echo /build/output/*/bin/*`" On 2015/09/02 03:09:53, krasin wrote: > I ...
5 years, 3 months ago (2015-09-05 03:10:07 UTC) #7
krasin
lgtm
5 years, 3 months ago (2015-09-08 16:10:29 UTC) #8
pcc1
thakis: Ping.
5 years, 3 months ago (2015-09-10 20:15:46 UTC) #9
pcc
On 2015/09/10 20:15:46, pcc1 wrote: > thakis: Ping. (I'll upload binaries after an LGTM from ...
5 years, 3 months ago (2015-09-10 20:17:03 UTC) #10
Nico
lgtm
5 years, 3 months ago (2015-09-11 19:54:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330433002/60001
5 years, 3 months ago (2015-09-11 20:08:17 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-11 20:19:23 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2b4b72b16d655c497dcc4693d3577bf01b71e992 Cr-Commit-Position: refs/heads/master@{#348478}
5 years, 3 months ago (2015-09-11 20:20:03 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:26:00 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2b4b72b16d655c497dcc4693d3577bf01b71e992
Cr-Commit-Position: refs/heads/master@{#348478}

Powered by Google App Engine
This is Rietveld 408576698