Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 899783003: Gold: Patch linker to fix LTO related bugs. (Closed)

Created:
5 years, 10 months ago by pcc
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, Nico, dcheng
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gold: Patch linker to fix LTO related bugs. Also ship the LTO plugin header so we can build LLVM against it. BUG=453195 R=thakis@chromium.org CC=thestig@chromium.org Committed: https://crrev.com/7208f4b68787eccb56af767ac87fc6f300be335c Cr-Commit-Position: refs/heads/master@{#314741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -2 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/binutils/build-all.sh View 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/binutils/plugin-dso-fix.patch View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/binutils/unlock-thin.patch View 1 chunk +129 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
pcc
5 years, 10 months ago (2015-02-05 02:52:38 UTC) #1
Nico
binutils -> over to Lei
5 years, 10 months ago (2015-02-05 03:00:19 UTC) #3
Lei Zhang
I presume both patches have been reviewed upstream?
5 years, 10 months ago (2015-02-05 03:27:28 UTC) #4
Lei Zhang
On 2015/02/05 03:27:28, Lei Zhang wrote: > I presume both patches have been reviewed upstream? ...
5 years, 10 months ago (2015-02-05 03:30:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899783003/1
5 years, 10 months ago (2015-02-05 03:33:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 03:52:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7208f4b68787eccb56af767ac87fc6f300be335c Cr-Commit-Position: refs/heads/master@{#314741}
5 years, 10 months ago (2015-02-05 03:54:32 UTC) #9
dcheng
5 years, 10 months ago (2015-02-05 08:16:26 UTC) #11
Message was sent while issue was closed.
Any chance this could have introduced this error?

Command: ../out/Debug/browser_tests --test-launcher-bot-mode
--test-launcher-summary-output=/tmp/isolated_out2lpJpD/output.json

../out/Debug/browser_tests: error while loading shared libraries: libwtf.so:
cannot open shared object file: No such file or directory

This is happening on
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)...

Powered by Google App Engine
This is Rietveld 408576698