Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Issue 2952213003: [ios clean] Refactors ToolsMenu and Tabs presentation (Closed)

Created:
3 years, 6 months ago by sczs
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] Refactors ToolsMenu presentation - Creates TransitionController objects so Coordinators don't have to conform to the UIViewControllerTransitioningDelegate protocol. This will make it easy to switch out to different transitions or make AB experiments. - Moves the presentationFrame calculation into the MenuPresentationController, which also reduces code duplication. In order to make this possible the MenuPresentationDelegate has changed. BUG=682880 Review-Url: https://codereview.chromium.org/2952213003 Cr-Commit-Position: refs/heads/master@{#481912} Committed: https://chromium.googlesource.com/chromium/src/+/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f

Patch Set 1 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -136 lines) Patch
M ios/clean/chrome/browser/ui/animators/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h View 1 chunk +22 lines, -0 lines 5 comments Download
A ios/clean/chrome/browser/ui/animators/zoom_transition_controller.mm View 1 chunk +34 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm View 2 chunks +39 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/presenters/menu_presentation_delegate.h View 1 chunk +7 lines, -5 lines 2 comments Download
M ios/clean/chrome/browser/ui/root/root_container_view_controller.mm View 1 chunk +5 lines, -31 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm View 1 chunk +5 lines, -31 lines 2 comments Download
M ios/clean/chrome/browser/ui/tab/tab_coordinator.mm View 5 chunks +7 lines, -27 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/BUILD.gn View 3 chunks +4 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/tools_coordinator.mm View 3 chunks +10 lines, -38 lines 0 comments Download
A ios/clean/chrome/browser/ui/tools/tools_menu_transition_controller.h View 1 chunk +25 lines, -0 lines 2 comments Download
A ios/clean/chrome/browser/ui/tools/tools_menu_transition_controller.mm View 1 chunk +36 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (6 generated)
sczs
PTAL https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h File ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h (right): https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h#newcode5 ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h:5: #ifndef IOS_CLEAN_CHROME_BROWSER_UI_ANIMATORS_ZOOM_TRANSITION_CONTROLLER_H_ I wasn't sure in which group ...
3 years, 6 months ago (2017-06-22 21:46:36 UTC) #4
marq (ping after 24h)
LGTM, good consolidation of code. https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h File ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h (right): https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h#newcode5 ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h:5: #ifndef IOS_CLEAN_CHROME_BROWSER_UI_ANIMATORS_ZOOM_TRANSITION_CONTROLLER_H_ On 2017/06/22 ...
3 years, 6 months ago (2017-06-23 09:18:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952213003/1
3 years, 6 months ago (2017-06-23 14:50:06 UTC) #7
sczs
Thanks for taking a look Mark! https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h File ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h (right): https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h#newcode5 ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h:5: #ifndef IOS_CLEAN_CHROME_BROWSER_UI_ANIMATORS_ZOOM_TRANSITION_CONTROLLER_H_ On ...
3 years, 6 months ago (2017-06-23 14:50:20 UTC) #8
lpromero
lgtm Refactor lgtm! https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h File ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h (right): https://codereview.chromium.org/2952213003/diff/1/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h#newcode11 ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h:11: // UIViewControllerTransitioningDelegate protocol and provides the ...
3 years, 6 months ago (2017-06-23 15:42:52 UTC) #9
sczs
Thanks for taking a look Louis, will make sure to implement your comments on the ...
3 years, 6 months ago (2017-06-23 15:52:35 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 16:09:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2141c4d83c85a4ebc5f2cf5d365d...

Powered by Google App Engine
This is Rietveld 408576698