ios/clean/chrome/browser/ui/presenters/menu_presentation_delegate.h - Issue 2952213003: [ios clean] Refactors ToolsMenu and Tabs presentation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/presenters/menu_presentation_delegate.h

Issue 2952213003: [ios clean] Refactors ToolsMenu and Tabs presentation (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h ('K') | « ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm ('k') | ios/clean/chrome/browser/ui/root/root_container_view_controller.mm » ('j') | ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_PRESENTERS_MENU_PRESENTATION_DELEGATE_H_	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_PRESENTERS_MENU_PRESENTATION_DELEGATE_H_

6 #define IOS_CLEAN_CHROME_BROWSER_UI_PRESENTERS_MENU_PRESENTATION_DELEGATE_H_	6 #define IOS_CLEAN_CHROME_BROWSER_UI_PRESENTERS_MENU_PRESENTATION_DELEGATE_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

10 // Protocol for an object to assist with menu presentation by providing a	10 // Protocol for an object to assist with menu presentation by providing

11 // frame for the menu.	11 // spatial information for the menu.

12 @protocol MenuPresentationDelegate	12 @protocol MenuPresentationDelegate

13 // Return the rect, in the coordinate space of the presenting view controller's	13 // Return the CGRect in which the Menu presentation will take place.
	lpromero 2017/06/23 15:42:51 Nit: Returns Nit: Returns sczs 2017/06/23 15:52:35 Acknowledged. Show quoted text On 2017/06/23 15:42:51, lpromero wrote: > Nit: Returns Acknowledged.
14 // view, that \|presentation\| should use for the presenting view controller.	14 - (CGRect)boundsForMenuPresentation;

15 - (CGRect)frameForMenuPresentation:(UIPresentationController*)presentation;	15 // Return the origin in the coordinate space of the presenting view controller's

	16 // view, in which the Menu presentation will present from.

	17 - (CGRect)originForMenuPresentation;

16 @end	18 @end

17	19

18 #endif // IOS_CLEAN_CHROME_BROWSER_UI_PRESENTERS_MENU_PRESENTATION_DELEGATE_H_	20 #endif // IOS_CLEAN_CHROME_BROWSER_UI_PRESENTERS_MENU_PRESENTATION_DELEGATE_H_

OLD	NEW