[ios clean] Refactors ToolsMenu and Tabs presentation

ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/tab/tab_container_view_controller.h"
 
 #import "ios/clean/chrome/browser/ui/ui_types.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
@@ skipping 162 matching lines @@
 - (void)detachChildViewController:(UIViewController*)viewController {
   if (viewController.parentViewController != self)
     return;
   [viewController willMoveToParentViewController:nil];
   [viewController.view removeFromSuperview];
   [viewController removeFromParentViewController];
 }
 
 #pragma mark - MenuPresentationDelegate
 
-- (CGRect)frameForMenuPresentation:(UIPresentationController*)presentation {
-  CGSize menuSize = presentation.presentedView.frame.size;
-  CGRect menuRect;
-  menuRect.size = menuSize;
-
-  CGRect menuOriginRect = [self rectForZoomWithKey:@"" inView:self.view];
-  if (CGRectIsNull(menuOriginRect)) {
-    menuRect.origin = CGPointMake(50, 50);
-    return menuRect;
-  }
-  // Calculate which corner of the menu the origin rect is in. This is
-  // determined by comparing frames, and thus is RTL-independent.
-  if (CGRectGetMinX(menuOriginRect) - CGRectGetMinX(self.view.bounds) <
-      CGRectGetMaxX(self.view.bounds) - CGRectGetMaxX(menuOriginRect)) {
-    // Origin rect is closer to the left edge of |self.view| than to the right.
-    menuRect.origin.x = CGRectGetMinX(menuOriginRect);
-  } else {
-    // Origin rect is closer to the right edge of |self.view| than to the left.
-    menuRect.origin.x = CGRectGetMaxX(menuOriginRect) - menuSize.width;
-  }
-
-  if (CGRectGetMinY(menuOriginRect) - CGRectGetMinY(self.view.bounds) <
-      CGRectGetMaxY(self.view.bounds) - CGRectGetMaxY(menuOriginRect)) {
-    // Origin rect is closer to the top edge of |self.view| than to the bottom.
-    menuRect.origin.y = CGRectGetMinY(menuOriginRect);
-  } else {
-    // Origin rect is closer to the bottom edge of |self.view| than to the top.
-    menuRect.origin.y = CGRectGetMaxY(menuOriginRect) - menuSize.height;
-  }
-
-  return menuRect;
+- (CGRect)boundsForMenuPresentation {
+  return self.view.bounds;
+}
+- (CGRect)originForMenuPresentation {
+  return [self rectForZoomWithKey:@"" inView:self.view];

[lpromero, 2017/06/23 15:42:52]

Why @"" here and nil above?

[sczs, 2017/06/23 15:52:35]

The ZoomDelegate handles nil and empty as different keys and has different
implementation for them. I will improve this on the follow up CL.

 }
 
 #pragma mark - ZoomTransitionDelegate
 
 - (CGRect)rectForZoomWithKey:(NSObject*)key inView:(UIView*)view {
   if ([self.toolbarViewController
           conformsToProtocol:@protocol(ZoomTransitionDelegate)]) {
     return [reinterpret_cast<id<ZoomTransitionDelegate>>(
         self.toolbarViewController) rectForZoomWithKey:key
                                                 inView:view];
@@ skipping 110 matching lines @@
         constraintEqualToAnchor:self.view.leadingAnchor],
     [self.toolbarView.trailingAnchor
         constraintEqualToAnchor:self.view.trailingAnchor],
     self.toolbarHeightConstraint,
     [self.toolbarView.bottomAnchor
         constraintEqualToAnchor:self.bottomLayoutGuide.topAnchor],
   ];
 }
 
 @end