Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 2952163002: Remove InProcessBrowserTest::SetUpOnMainThread() calls. (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 class AutofillTest : public InProcessBrowserTest { 102 class AutofillTest : public InProcessBrowserTest {
103 protected: 103 protected:
104 AutofillTest() {} 104 AutofillTest() {}
105 105
106 void SetUpOnMainThread() override { 106 void SetUpOnMainThread() override {
107 // Don't want Keychain coming up on Mac. 107 // Don't want Keychain coming up on Mac.
108 test::DisableSystemServices(browser()->profile()->GetPrefs()); 108 test::DisableSystemServices(browser()->profile()->GetPrefs());
109 109
110 ASSERT_TRUE(embedded_test_server()->Start()); 110 ASSERT_TRUE(embedded_test_server()->Start());
111 InProcessBrowserTest::SetUpOnMainThread();
112 } 111 }
113 112
114 void TearDownOnMainThread() override { 113 void TearDownOnMainThread() override {
115 // Make sure to close any showing popups prior to tearing down the UI. 114 // Make sure to close any showing popups prior to tearing down the UI.
116 content::WebContents* web_contents = 115 content::WebContents* web_contents =
117 browser()->tab_strip_model()->GetActiveWebContents(); 116 browser()->tab_strip_model()->GetActiveWebContents();
118 AutofillManager* autofill_manager = 117 AutofillManager* autofill_manager =
119 ContentAutofillDriverFactory::FromWebContents(web_contents) 118 ContentAutofillDriverFactory::FromWebContents(web_contents)
120 ->DriverForFrame(web_contents->GetMainFrame()) 119 ->DriverForFrame(web_contents->GetMainFrame())
121 ->autofill_manager(); 120 ->autofill_manager();
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
804 IN_PROC_BROWSER_TEST_F(AutofillTest, 803 IN_PROC_BROWSER_TEST_F(AutofillTest,
805 DISABLED_MergeAggregatedDuplicatedProfiles) { 804 DISABLED_MergeAggregatedDuplicatedProfiles) {
806 int num_of_profiles = 805 int num_of_profiles =
807 AggregateProfilesIntoAutofillPrefs("dataset_duplicated_profiles.txt"); 806 AggregateProfilesIntoAutofillPrefs("dataset_duplicated_profiles.txt");
808 807
809 ASSERT_GT(num_of_profiles, 808 ASSERT_GT(num_of_profiles,
810 static_cast<int>(personal_data_manager()->GetProfiles().size())); 809 static_cast<int>(personal_data_manager()->GetProfiles().size()));
811 } 810 }
812 811
813 } // namespace autofill 812 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/app_controller_mac_browsertest.mm ('k') | chrome/browser/banners/app_banner_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698