chrome/browser/permissions/permission_request_manager_browsertest.cc - Issue 2952163002: Remove InProcessBrowserTest::SetUpOnMainThread() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_manager_browsertest.cc

Issue 2952163002: Remove InProcessBrowserTest::SetUpOnMainThread() calls. (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_browsertest.cc ('k') | chrome/browser/permissions/permissions_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_request_manager_browsertest.cc

diff --git a/chrome/browser/permissions/permission_request_manager_browsertest.cc b/chrome/browser/permissions/permission_request_manager_browsertest.cc

index a6de20af8ceb0870c4ebb6f5f7b842fe3a327dbf..86a3c396e3c0aac86e6ec630c630aa175bf53220 100644

--- a/chrome/browser/permissions/permission_request_manager_browsertest.cc

+++ b/chrome/browser/permissions/permission_request_manager_browsertest.cc

@@ -78,7 +78,6 @@ class PermissionRequestManagerBrowserTest : public InProcessBrowserTest {

~PermissionRequestManagerBrowserTest() override = default;

void SetUpOnMainThread() override {

- InProcessBrowserTest::SetUpOnMainThread();

PermissionRequestManager* manager = GetPermissionRequestManager();

mock_permission_prompt_factory_.reset(

new MockPermissionPromptFactory(manager));

@@ -127,7 +126,6 @@ class PermissionDialogTest

void SetUpOnMainThread() override {

// Skip super: It will install a mock permission UI factory, but for this

// test we want to show "real" UI.

- InProcessBrowserTest::SetUpOnMainThread();

ui_test_utils::NavigateToURL(browser(), GetUrl());

}